Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Symfony 6] Fix setting deprecations on pagerfanta bridge pass #413

Merged
merged 1 commit into from
Apr 19, 2022
Merged

[Symfony 6] Fix setting deprecations on pagerfanta bridge pass #413

merged 1 commit into from
Apr 19, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Apr 7, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner April 7, 2022 15:16
@loic425 loic425 mentioned this pull request Apr 7, 2022
Closed
16 tasks
@loic425 loic425 changed the title Fix setting deprecations on pagerfanta bridge pass [Symfony 6] Fix setting deprecations on pagerfanta bridge pass Apr 7, 2022
@loic425 loic425 changed the base branch from 1.9 to 1.10 April 12, 2022 08:14
lchrusciel
lchrusciel reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one requires rebase :/

@lchrusciel lchrusciel added the Maintenance Configurations, READMEs, releases, etc. label Apr 15, 2022
@lchrusciel lchrusciel merged commit d3d94ea into Sylius:1.10 Apr 19, 2022
@lchrusciel
Copy link
Member

Thank you, Loïc! 🎉

@loic425 loic425 deleted the fix/set-deprecations branch April 19, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loic425 @lchrusciel