Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Symfony 4 support #430

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Drop Symfony 4 support #430

merged 1 commit into from
Apr 15, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Apr 15, 2022 •
edited

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner April 15, 2022 12:15
lchrusciel
lchrusciel reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add deprecation removal from last merges as well here?

lchrusciel
lchrusciel approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we agreed, it will be part of next PR

@lchrusciel lchrusciel added the Maintenance Configurations, READMEs, releases, etc. label Apr 15, 2022
@lchrusciel lchrusciel merged commit c7f57fb into Sylius:1.10 Apr 15, 2022
@loic425 loic425 deleted the drop-symfony-4 branch April 15, 2022 12:18
@lchrusciel lchrusciel mentioned this pull request Apr 16, 2022
Merged
lchrusciel added a commit that referenced this pull request Apr 16, 2022
@lchrusciel
minor #435 [Maintenance] Removal of Sf4.4 BC layer leftovers (lchrusc…
a303971 
…iel)

This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | Update of #401 after #430
| License         | MIT


Commits
-------

dfd1eb3 [Maintenance] Removal of Sf4.4 BC layer leftovers
@lchrusciel lchrusciel mentioned this pull request Apr 20, 2022
Merged
lchrusciel added a commit that referenced this pull request Apr 20, 2022
@lchrusciel
refactor #445 [Maintenance] Drop Sf4 ACL on parameters class due to l…
bfdbc9f 
…ack of its support (lchrusciel)

This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | Continuation of #430 and #428
| License         | MIT


Commits
-------

1b0501c [Maintenance] Drop Sf4 ACL on parameters class due to lack of its support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loic425 @lchrusciel