[Symfony 6] Third solution to fix resource controllers #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Apr 20, 2022
loic425
commented
| Q | A |
|---|---|
| Bug fix? | yes (for Symfony 6) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | partially #400 |
| License | MIT |
lchrusciel
reviewed
Apr 20, 2022
| use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | ||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
|
|
||
| final class TwigPass implements CompilerPassInterface |
There was a problem hiding this comment.
Let's add note, that this class will be removed in Resource 2.0
There was a problem hiding this comment.
Shouldn't we deprecate this class and inform about removing setting twig as public service in the UPGRADE file?
There was a problem hiding this comment.
I think deprecate it should be landed with Sylius resource controller split (next release). Cause we need this usage for this release and can not remove using it.
lchrusciel
approved these changes
Apr 20, 2022
This was referenced Apr 20, 2022
|
Thank you, Loïc! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Apr 20, 2022
This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | yes | BC breaks? | I hope no | Deprecations? | no | Related tickets | #400 | License | MIT Commits ------- 367a014 Add support for Symfony 6 0c2c50c Fix parameters service for Symfony 6 1bf22bc Allow grid bundle symfony 6 branch a420b52 Fix Psalm errors 43d63f3 Fix PHPStan errors 6e7b7a8 Fix Phpspec for Symfony 6 0c81c2c Commit suggestions 0cb7c9a Apply suggestions from code review 1d165a0 Fix eb465b8 Simplify tests 73d533d bug #439 Fix Phpspec for symfony 6 (loic425) dad9a5c Fix wrong error from Psalm 4a3b340 Make Twig public to fix resource controller c95b968 Fix coding standard dc22e5b Add a note to remove Twig pass on sylius resource bundle 2.0 af233d7 bug #444 [Symfony 6] Third solution to fix resource controllers (loic425)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.