Fix coding standards to fix the build #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Bug
Zales0123
force-pushed
the
fix-coding-standards
branch
11 times, most recently
from
87cef06
to
143da71
Compare
Zales0123
force-pushed
the
fix-coding-standards
branch
4 times, most recently
from
1e960bb
to
d6f6890
Compare
Zales0123
force-pushed
the
fix-coding-standards
branch
from
d6f6890
to
50ed9b9
Compare
GSadee
approved these changes
Jun 24, 2022
Zales0123
force-pushed
the
fix-coding-standards
branch
from
64307fc
to
9f6e514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: I had to upgrade PHPStan to a more modern version (we should've done it a long time ago 馃拑) to make it work with PHP 8.1. Therefore, it resulted in a little bit more changes and skips than expected, but at least it unblocks us with the development 馃枛