Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpspec/phpspec to 7.3 #545

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Update phpspec/phpspec to 7.3 #545

merged 1 commit into from
Feb 5, 2023

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Dec 27, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

@dannyvw dannyvw requested a review from a team as a code owner December 27, 2022 10:12
@lchrusciel lchrusciel changed the base branch from poc-new-resource-metadata to 1.11 February 3, 2023 19:16
@lchrusciel lchrusciel changed the base branch from 1.11 to poc-new-resource-metadata February 3, 2023 19:16
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Danny,

thanks a lot for proposal. Can you fix psalm and ping me on slack to have it merged?

In the meantime, I've changed the branch, so it can land quicker into the release

@lchrusciel lchrusciel changed the base branch from poc-new-resource-metadata to 1.11 February 3, 2023 19:18
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "phpspec" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel merged commit 99a9869 into Sylius:1.11 Feb 5, 2023
@dannyvw dannyvw deleted the phpspec branch February 6, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants