Define simple vars on your operations #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Aug 31, 2023
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
loic425
force-pushed
the
feature/operation-vars
branch
from
baec515
to
686b9b8
Compare
Prometee
approved these changes
Sep 1, 2023
diimpp
reviewed
Sep 1, 2023
|
Is this PR part of bigger initiative? For example, will be vars made translatable? |
The template is responsible of the translation, there is no need to manage translations in this bundle. |
lchrusciel
approved these changes
Sep 9, 2023
Comment on lines
+59
to
+63
| if (null === $resourceVars = $resource->getVars()) { | ||
| return $operation; | ||
| } | ||
|
|
||
| return $operation->withVars(\array_merge($resourceVars, $operation->getVars() ?? [])); |
There was a problem hiding this comment.
Suggested change
| if (null === $resourceVars = $resource->getVars()) { | |
| return $operation; | |
| } | |
| return $operation->withVars(\array_merge($resourceVars, $operation->getVars() ?? [])); | |
| return $operation->withVars( | |
| \array_merge($resource->getVars() ?? [], $operation->getVars() ?? []) | |
| ); |
or even
Suggested change
| if (null === $resourceVars = $resource->getVars()) { | |
| return $operation; | |
| } | |
| return $operation->withVars(\array_merge($resourceVars, $operation->getVars() ?? [])); | |
| return $operation->withVars($operation->getVars() ?? [] + $resource->getVars()); |
Zales0123
reviewed
Sep 9, 2023
| @@ -315,6 +317,7 @@ public function it_displays_the_metadata_for_given_resource_operation(): void | |||
| routePrefix null | |||
| redirectToRoute null | |||
| redirectArguments null | |||
| vars null | |||
There was a problem hiding this comment.
Would be great to have those vars set up in one of these tests and check if they're properly displayed
|
Thank you, Loïc! 🥇 |
Zales0123
added a commit
that referenced
this pull request
Sep 11, 2023
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Related to #742 (comment) comment Commits ------- 9966ce5 Improve testing debug resource command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.