Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Component namespace on action #758

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Remove Component namespace on action #758

merged 1 commit into from
Oct 24, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Oct 23, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner October 23, 2023 07:36
@loic425 loic425 force-pushed the move-component-namespace/action branch from d09523a to 6f6617f Compare October 23, 2023 07:38
diimpp
diimpp approved these changes Oct 23, 2023
View reviewed changes
src/Component/Action/PlaceHolderAction.php Outdated Show resolved Hide resolved
lchrusciel
lchrusciel reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all in favour of this change about the namespace, but there is no point in doing a migration layer for something that didn't reach official release

@loic425
Copy link
Member Author

loic425 commented Oct 23, 2023

I'm all in favour of this change about the namespace, but there is no point in doing a migration layer for something that didn't reach official release

Indeed, but I prefer to use the same bc-layer for every moved classes/interfaces to avoid errors (even if they are new).

@loic425 loic425 force-pushed the move-component-namespace/action branch from e465603 to 1a3c7b6 Compare October 24, 2023 06:52
@loic425 loic425 force-pushed the move-component-namespace/action branch from 1a3c7b6 to 40f0e34 Compare October 24, 2023 06:53
@lchrusciel lchrusciel merged commit ca05fca into Sylius:1.11 Oct 24, 2023
60 checks passed
@lchrusciel
Copy link
Member

Thank you, @loic425!

@loic425 loic425 deleted the move-component-namespace/action branch October 24, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp diimpp approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loic425 @lchrusciel @diimpp