Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Component namespace on context #760

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Remove Component namespace on context #760

merged 1 commit into from
Oct 24, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Oct 23, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner October 23, 2023 09:33
@loic425 loic425 force-pushed the move-component-namespace/context branch 5 times, most recently from b23cc30 to a7ddec5 Compare October 24, 2023 13:02
@loic425 loic425 force-pushed the move-component-namespace/context branch from a7ddec5 to e409f8e Compare October 24, 2023 13:04
diimpp
diimpp approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to BC layer for moved classes?

@loic425
Copy link
Member Author

loic425 commented Oct 24, 2023

No need to BC layer for moved classes?

No, it has been introduced on 1.11 alpha.1

@lchrusciel lchrusciel merged commit f0ff413 into Sylius:1.11 Oct 24, 2023
60 checks passed
@lchrusciel
Copy link
Member

Thank you, @loic425!

@loic425 loic425 deleted the move-component-namespace/context branch October 25, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp diimpp approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loic425 @lchrusciel @diimpp