Missed typehint for TranslatableFactoryInterface
#765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diimpp
approved these changes
Oct 27, 2023
Rafikooo
force-pushed
the
type-hint-translatable-factory
branch
from
43ebf44
to
c73ce87
Compare
Rafikooo
force-pushed
the
type-hint-translatable-factory
branch
from
4fb6897
to
a830b79
Compare
Wojdylak
approved these changes
Oct 30, 2023
loic425
approved these changes
Oct 31, 2023
Zales0123
approved these changes
Nov 2, 2023
|
Thank you, Rafał! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with a type hint of:
https://github.com/Sylius/Sylius/blob/1.13/src/Sylius/Component/Product/Factory/ProductFactoryInterface.php
in the end application because the implemented interface is missing annotations
https://github.com/Sylius/SyliusResourceBundle/blob/1.10/src/Component/Factory/FactoryInterface.php