Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phpunit tests for Symfony deserialize listener #779

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Phpunit tests for Symfony deserialize listener #779

merged 4 commits into from
Nov 20, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Nov 10, 2023 •
edited

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Before moving forward to remove this listener and transform it to a DeserialiseProvider, let's use PHPUnit first.

@loic425 loic425 requested a review from a team as a code owner November 10, 2023 09:12
@loic425 loic425 force-pushed the phpspec2phpunit/symfony/event-listener branch from 0061330 to 2b1426a Compare November 17, 2023 16:11
@lchrusciel lchrusciel merged commit 82af9cd into Sylius:1.11 Nov 20, 2023
60 checks passed
@lchrusciel
Copy link
Member

Thank you, @loic425!

@loic425 loic425 deleted the phpspec2phpunit/symfony/event-listener branch November 20, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate left review comments

@diimpp diimpp diimpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@loic425 @lchrusciel @diimpp @NoResponseMate