Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some namespaces on metadata #804

Merged
merged 7 commits into from
Dec 6, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Nov 29, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner November 29, 2023 11:37
@loic425 loic425 changed the title Move component namespace/metadata Move some namespaces on metadata Nov 29, 2023
@loic425 loic425 force-pushed the move-component-namespace/metadata branch from 487db92 to a327e30 Compare November 29, 2023 11:39
src/Bundle/Resources/config/services.xml Outdated Show resolved Hide resolved
src/Component/src/Metadata/Metadata.php Show resolved Hide resolved
src/Component/src/Metadata/Metadata.php Show resolved Hide resolved
src/Component/src/Metadata/Metadata.php Show resolved Hide resolved
src/Component/src/Metadata/Metadata.php Show resolved Hide resolved
src/Component/tests/spec/Metadata/MetadataSpec.php Outdated Show resolved Hide resolved
src/Component/tests/spec/Metadata/MetadataSpec.php Outdated Show resolved Hide resolved
src/Component/tests/spec/Metadata/MetadataSpec.php Outdated Show resolved Hide resolved
src/Component/tests/spec/Metadata/MetadataSpec.php Outdated Show resolved Hide resolved
Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
@lchrusciel lchrusciel merged commit 1ee5198 into Sylius:1.11 Dec 6, 2023
60 checks passed
@lchrusciel
Copy link
Member

Thank you, @loic425!

@loic425 loic425 deleted the move-component-namespace/metadata branch December 6, 2023 13:13
lchrusciel added a commit that referenced this pull request Dec 9, 2023
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

Based on #804

Commits
-------

f906ded Move some namespaces on generator
11f8e43 Add a deprecation message
d2cf42e Remove deprecation message, it fails
87db927 Fix deprecation message
eec5022 Update src/Bundle/Resources/config/services.xml

Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants