Move some namespaces on generator #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
move-component-namespace/generator
branch
from
05fa857
to
7ff277d
Compare
loic425
changed the title
diimpp
reviewed
Nov 29, 2023
loic425
force-pushed
the
move-component-namespace/generator
branch
3 times, most recently
from
1611e43
to
86cc80f
Compare
diimpp
reviewed
Nov 30, 2023
loic425
force-pushed
the
move-component-namespace/generator
branch
from
86cc80f
to
87db927
Compare
Co-authored-by: Dmitri Perunov <diimpp@gmail.com>
diimpp
approved these changes
Dec 6, 2023
|
Thank you, @loic425! |
lchrusciel
added a commit
that referenced
this pull request
Dec 12, 2023
This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Based on #805 Only ClassReflection needs a bc-layer cause the other classes have been introduced in 1.11. Commits ------- ffeaa37 Move some namespaces on reflection b98ab44 Apply suggestions from code review cea38d6 Remove an unnecessary empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #804