Add support for Symfony 6.4 #809
Conversation
loic425
commented
Dec 1, 2023
loic425
commented
| Q | A |
|---|---|
| Bug fix? | yes (cause we do not exclude it on composer) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
loic425
force-pushed
the
fix/support-for-symfony-6.4
branch
from
9abea6b
to
b746e74
Compare
| /** | ||
| * @internal | ||
| */ | ||
| trait ContainerAwareTrait |
There was a problem hiding this comment.
I've copied the Symfony trait cause it's now deprecated
There was a problem hiding this comment.
It is deprecated but not removed in 6.4, so do we really need to copy it in this version? 🤔
There was a problem hiding this comment.
Yeah but it's removed on 7.0... But right, maybe adding it in 1.11 (the current development one which contains the new resource metadata system).
| @@ -71,6 +71,7 @@ | |||
| "sylius/grid-bundle": "^1.7 || v1.12.0-ALPHA.1", | |||
| "symfony/dependency-injection": "^5.4 || ^6.0", | |||
| "symfony/dotenv": "^5.4 || ^6.0", | |||
| "symfony/stopwatch": "^5.4 || ^6.0", | |||
There was a problem hiding this comment.
I've added this cause there is a bug with workflow without stopwatch.
These 2 ones are on dev requirements
| /* | ||
| * This file is part of the Sylius package. | ||
| * | ||
| * (c) Paweł Jędrzejewski |
There was a problem hiding this comment.
| * (c) Paweł Jędrzejewski | |
| * (c) Sylius Sp. z o.o. |
There was a problem hiding this comment.
We did this on the 1.11 branch, but not on the 1.10 (for bugfix)
| /** | ||
| * @internal | ||
| */ | ||
| trait ContainerAwareTrait |
There was a problem hiding this comment.
It is deprecated but not removed in 6.4, so do we really need to copy it in this version? 🤔
loic425
force-pushed
the
fix/support-for-symfony-6.4
branch
2 times, most recently
from
60daf2d
to
cd37a8d
Compare
loic425
force-pushed
the
fix/support-for-symfony-6.4
branch
from
b759532
to
d6e8ea6
Compare
|
Thank you, Loïc! 🎉 |
… 2.0 (GSadee, loic425) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | after #809 | License | MIT Fix after upmerge Commits ------- 1983dc7 [CI] Exclude builds for Symfony 6.4 and doctrine/persistence 2.0 891cdf4 Fix PHPUnit tests
