Add main controller #824
Merged
Add main controller #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
reviewed
Dec 16, 2023
Comment on lines
+49
to
+52
| $valid = $request->attributes->getBoolean('is_valid', true); | ||
| if (!$valid) { | ||
| $operation = $operation->withWrite(false); | ||
| } |
There was a problem hiding this comment.
Suggested change
| $valid = $request->attributes->getBoolean('is_valid', true); | |
| if (!$valid) { | |
| $operation = $operation->withWrite(false); | |
| } | |
| $operation = $operation->withWrite($request->attributes->getBoolean('is_valid', true)); |
But I wonder if is_valid should not be false by default
There was a problem hiding this comment.
If we configure "validate: false" on an operation, we don't have this attribute on request.
There was a problem hiding this comment.
I do not agree with your suggestion, the developer could configure Create(write: false), validation is ok, and then it will write and developer does not want that.
lchrusciel
approved these changes
Dec 16, 2023
diimpp
reviewed
Dec 17, 2023
diimpp
approved these changes
Dec 18, 2023
|
Thank you, @loic425! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #817