Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache on metadata when debug is enabled #836

Merged

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jan 11, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

On dev, when updating metadata, the metadata (and so the routing) was in cache due to this service. But on dev/test environment, we don't need that cache, we need to update the routing while configuring the attributes on our Sylius resources.

@loic425 loic425 requested a review from a team as a code owner January 11, 2024 10:42
@loic425 loic425 added the Bug Confirmed bugs or bugfixes. label Jan 11, 2024
@GSadee GSadee merged commit 8325867 into Sylius:1.11 Jan 12, 2024
24 checks passed
@GSadee
Copy link
Member

GSadee commented Jan 12, 2024

Thank you, Loïc! 🥇

@loic425 loic425 deleted the fix/remove-cache-on-metadata-when-debug-is-enabled branch January 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants