Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Symfony 6 #121

Merged
merged 12 commits into from
Jul 8, 2022
Merged

Add support for Symfony 6 #121

merged 12 commits into from
Jul 8, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jul 6, 2022 •
edited
Loading

Continuation of #119

@loic425 loic425 force-pushed the sf6 branch 2 times, most recently from 530d1db to c3bccd5 Compare July 6, 2022 15:35
@loic425 loic425 mentioned this pull request Jul 6, 2022
Closed
lchrusciel
lchrusciel approved these changes Jul 8, 2022
View reviewed changes
src/Filesystem/Filesystem.php
@@ -15,10 +15,82 @@

use Symfony\Component\Filesystem\Filesystem as BaseFilesystem;

final class Filesystem extends BaseFilesystem implements FilesystemInterface
final class Filesystem implements FilesystemInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've duplicated the contract of this class to run exists twice and getFileContents once... We should deprecate this class and propose better abstraction (suited for our usecase)

@lchrusciel lchrusciel added Feature New feature proposals. Maintenance Configurations, READMEs, releases, etc. labels Jul 8, 2022
@lchrusciel lchrusciel merged commit 4fee7f4 into Sylius:2.3 Jul 8, 2022
@lchrusciel
Copy link
Member

Thanks a lot, Jean-Baptiste and Loic! Your rock! 👯

@lchrusciel lchrusciel mentioned this pull request Jul 8, 2022
Closed
@loic425 loic425 deleted the sf6 branch July 11, 2022 07:21
@loic425 loic425 mentioned this pull request Jul 11, 2022
Closed
@alexander-schranz
Copy link
Contributor

alexander-schranz commented Jul 15, 2022 •
edited
Loading

Good work here 👍

@lchrusciel Do you know if there is a release planned soon? We want to create a release of sulu/theme-bundle with support for Symfony 6 as Sulu with latest 2.5 release is shipped with Symfony 6.

@loic425
Copy link
Member Author

loic425 commented Jul 19, 2022

Good work here +1

@lchrusciel Do you know if there is a release planned soon? We want to create a release of sulu/theme-bundle with support for Symfony 6 as Sulu with latest 2.5 release is shipped with Symfony 6.

@alexander-schranz Just follow our issue for Symfony 6 support

@alexander-schranz
Copy link
Contributor

@loic425 I'm aware of that issue but could the syliusthemebundle not released without the sylius core as it does not have any requirements to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Feature New feature proposals. Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@loic425 @lchrusciel @alexander-schranz @macintoshplus