Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Symfony to 4.4 #35

Merged
merged 4 commits into from
Feb 20, 2020
Merged

Update Symfony to 4.4 #35

merged 4 commits into from
Feb 20, 2020

Conversation

Tomanhez
Copy link
Contributor

No description provided.

@GSadee GSadee added the Maintenance Configurations, READMEs, releases, etc. label Feb 20, 2020
@Tomanhez Tomanhez force-pushed the update-symfony-to-4.4-and-5.0 branch 2 times, most recently from ce362d0 to e662d28 Compare February 20, 2020 11:26
@Tomanhez Tomanhez changed the title Update Symfony to 4.4 and 5.0 Update Symfony to 4.4 Feb 20, 2020
GSadee
GSadee approved these changes Feb 20, 2020
View reviewed changes
src/Asset/Package/PathPackage.php Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the update-symfony-to-4.4-and-5.0 branch 3 times, most recently from 648db01 to 040fae7 Compare February 20, 2020 14:07
@Tomanhez Tomanhez force-pushed the update-symfony-to-4.4-and-5.0 branch 2 times, most recently from 7e96ed5 to 38f6813 Compare February 20, 2020 14:35
@Tomanhez Tomanhez force-pushed the update-symfony-to-4.4-and-5.0 branch from 38f6813 to 90238ed Compare February 20, 2020 14:53
@GSadee GSadee merged commit 0cd4c8a into Sylius:master Feb 20, 2020
@GSadee
Copy link
Member

GSadee commented Feb 20, 2020

Thank you, Tomasz! 🥇

@wadjeroudi
Copy link
Contributor

@GSadee @pamil I think this PR deserves a release ? last release is quite old.
Thank you.

NB: The last release requires symfony/translation-contracts ^1.0 and randomly collide with a sylius 1.7 install (sometimes composer takes the translation contracts 1 and sometimes the 2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tomanhez @GSadee @wadjeroudi @Zales0123