New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GTP primitives to artix7 architectures #2112
Conversation
f8bfc4e
to
ac5fe6b
Compare
Apart from 200T vendor check, and install, all the other CIs went green. I am not sure what went wrong in the failing ones:
|
Looks like Vivado got stuck on the
|
Likely a disk-space overflow on toolchain test failure. Should probably fix that. |
I wonder what this could be due to... no GTP test is currently performed in the diff_fasm flow, so "hopefully" this is an intermittent issue. I'll try to reproduce it locally
Ok, thanks for the info, I'll try to figure out what is happening here |
I have added the XML autogeneration with timings from the SDF directory and modified the [autogeneration script] Given that the cells_sim and techmap require some manual modifications, those are not part of the flow at the moment, at least until a better generalization mechanism is added for those files. |
7634ea5
to
2a0cb4a
Compare
This was actually due to a missing update to the toolchain wrappers, as the device info needs to be available now at placement constriants generation, to correctly constrain IOPADs of the GTP tiles at the correct sub_tile location. Fixed now |
8f8a546
to
7a12efe
Compare
@litghost CI went green, this PR is ready for review. Given that the XML autogeneration requires f4pga/prjxray#1628, for now the XML are checked-in, and can either be removed later on, or we can wait for f4pga/prjxray#1628 to land and the output integrated in the db |
2d7aa58
to
6d0ed08
Compare
|
||
sites[site.type].append((site, input_wires, output_wires)) | ||
# If enabled, sort sites by name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there ever a reason to not sort them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually yes, I bumped into an issue after applying sorting to all the capacity, I got an error for which the SLICEM and SLICEL were swapped in the sub_tile definitions, causing the wrong prefix to be assigned, given the different placement.
Thinking about it, I might have missed to sort also when generating the architecture layout, therefore having the tiles and their location prefixes not in sync.
As a long term more robust solution though, we would need to enhance VPR so that the sub_tile index is not defined by the order of the sub tile, but by an attribute that we can control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the tile prefix ordering in the arch-layout, so now all sites are sorted.
@acomodi - I'm updating the base image to fix the permission issue. |
e063151
to
d8d2997
Compare
@mithro seems to be working now, thanks. There seems to be yet another issue with the vendor tool tests |
d8d2997
to
de2cba4
Compare
@acomodi - It seems the disks are getting automounted now. |
de2cba4
to
31d57b3
Compare
abb9ce6
to
e8106ad
Compare
Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
This also adds placement constraints capabilities addition to correctly place the various tiles and blocks at the right location, based on the device database. Signed-off-by: Alessandro Comodi <acomodi@antmicro.com> Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com> Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com> Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com> Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com> Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
e8106ad
to
531f7c9
Compare
This is a PR which adds GTP primitives to the SymbiFlow toolchain:
For artix7 achitectures: