Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit CEUSEDMUX and SRUSEDMUX support. #576

Merged
merged 2 commits into from Apr 16, 2019
Merged

Add explicit CEUSEDMUX and SRUSEDMUX support. #576

merged 2 commits into from Apr 16, 2019

Conversation

litghost
Copy link
Contributor

This has been tested with #575

@litghost
Add explicit CEUSEDMUX and SRUSEDMUX support.
d301010 
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
@probot-autolabeler probot-autolabeler bot added lang-verilog Issue uses (or requires) Verilog language. lang-xml Issues uses (or requires) XML language. type-vpr labels Apr 11, 2019
@litghost litghost requested review from mkurc-ant, mithro, elms and kgugala and removed request for mkurc-ant April 11, 2019 16:56
@litghost litghost changed the title Add explicit CEUSEDMUX and SRUSEDMUX support. WIP: Add explicit CEUSEDMUX and SRUSEDMUX support. Apr 11, 2019
@litghost
Copy link
Contributor Author

This breaks on non-trival examples, investigating.

@litghost
Copy link
Contributor Author

This breaks on non-trival examples, investigating.

Looks like pack patterns were required, but they are nasty. I'll commit the "working" version, and begin thinking about how to make the pack pattern generation suck less.

@litghost
Add awful pack patterns as interm solution.
ec3fcab 
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
@litghost
Copy link
Contributor Author

litghost commented Apr 11, 2019 •
edited

This breaks on non-trival examples, investigating.

Looks like pack patterns were required, but they are nasty. I'll commit the "working" version, and begin thinking about how to make the pack pattern generation suck less.

Using pack patterns solves the packing issue at the cost of the typical VPR packing problem, which is that it no longer packs consumes all the FF's in the slice. Investigating ...

@mithro
Copy link
Contributor

mithro commented Apr 11, 2019

The pack pattern is a be horrific but otherwise looks okay I think?

@litghost
Copy link
Contributor Author

The pack pattern is a be horrific but otherwise looks okay I think?

Amazingly the CI shows green, so that means murax pack/placed/routed! I want to make those pack patterns generated (rather than hand written), and I also need to verify resource usage. It's unclear if VPR can pack all 8 FF's into a SLICE any more with this PR.

@mkurc-ant
Copy link
Collaborator

@litghost So with this PR the VPR will be able to use VCC and GND local to CEUSEDMUX and SEUSEDMUX ?

BTW I like the comment "... to make the pack pattern generation suck less" ;)

@litghost
Copy link
Contributor Author

@litghost So with this PR the VPR will be able to use VCC and GND local to CEUSEDMUX and SEUSEDMUX ?

Exactly!

@litghost litghost mentioned this pull request Apr 15, 2019
Merged
@litghost
Copy link
Contributor Author

litghost commented Apr 15, 2019 •
edited

Using #591 I've determined that this PR does not increase sum CLB usage for any of the basys3 test bitstreams. Given that, I'll focus on making the pack pattern output be less terrible. This is probably a good time to migrate to v2x, and hopefully I can compactly express the required pack pattern there without too much trouble using generate statements.

@litghost
Copy link
Contributor Author

litghost commented Apr 15, 2019 •
edited by unfurl-links bot

Using #591 I've determined that this PR does need increase sum CLB usage for any of the basys3 test bitstreams. Given that, I'll focus on making the pack pattern output be less terrible. This is probably a good time to migrate to v2x, and hopefully I can compactly express the required pack pattern there without too much trouble using generate statements.

https://gist.github.com/litghost/5208eb5304e441cd281ec08aa4a0c975 has the data in CSV format. Data points:

  • ff_pack: Results from this PR
  • no_ff_pack: Results from master
  • round_robin_ff_pack: Results from this PR with round robin turned on
Gist
Comparision of master and CE/SR usage PR. GitHub Gist: instantly share code, notes, and snippets.

@litghost litghost changed the title WIP: Add explicit CEUSEDMUX and SRUSEDMUX support. Add explicit CEUSEDMUX and SRUSEDMUX support. Apr 15, 2019
mithro
mithro approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@litghost litghost merged commit 45be450 into f4pga:master Apr 16, 2019
@litghost litghost deleted the new_sr_ce_on_master branch April 16, 2019 17:12
@litghost litghost mentioned this pull request Apr 27, 2019
Closed
mkurc-ant referenced this pull request in antmicro/f4pga-arch-defs Oct 6, 2021
@sharmaln
Merge pull request #576 from antmicro/eos-mult-valid
12d521e 
Update EOS-S3 MULT support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

@mkurc-ant mkurc-ant Awaiting requested review from mkurc-ant

@elms elms Awaiting requested review from elms

@kgugala kgugala Awaiting requested review from kgugala

Assignees
No one assigned
Labels
lang-verilog Issue uses (or requires) Verilog language. lang-xml Issues uses (or requires) XML language. type-vpr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@litghost @mithro @mkurc-ant