Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example/Notebook] Jupyer Notebook Server and Client Example Contain Old Code Leads Error #177

Open
mtang724 opened this issue Oct 5, 2022 · 2 comments · Fixed by #178
Labels
bug Something isn't working

Comments

@mtang724
Copy link

mtang724 commented Oct 5, 2022

What happened + What you expected to happen

In FedScale/examples/notebook, the server and client contain old code "from fedscale.core.logger.execution import args" which suppose to be in new form "import fedscale.core.config_parser as parser" -> args = parser.args

Versions / Dependencies

FedScale 0.5, pip install -e .

Reproduction script

It happened when I tried to run the example code in jupyter notebook after installation. So it would be great to fix it to not to confuse new users.

Issue Severity

Low: It annoys or frustrates me.

@mtang724 mtang724 added the bug Something isn't working label Oct 5, 2022
@fanlai0990
Copy link
Member

fanlai0990 commented Oct 5, 2022

@IKACE Can you please fix this due to the last commit? #175 Thanks!

@IKACE
Copy link
Contributor

IKACE commented Oct 5, 2022

Thank you for catching this bug! I've submitted a fix PR to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants