You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this case I'd return an error here... Even better suggestion is to make the Response just be a []byte so that clients can marshal into their own structs, and get rid of readStream entirely.
The library uses
panic
in cases where it can return an error. Suggest in cases where multiple errors be returned to return the first error.SynapseGo/request.go
Lines 56 to 58 in 9d3ed7f
SynapseGo/request.go
Lines 84 to 86 in 9d3ed7f
SynapseGo/request.go
Lines 112 to 114 in 9d3ed7f
SynapseGo/request.go
Lines 133 to 135 in 9d3ed7f
In this case I'd return an error here... Even better suggestion is to make the
Response
just be a[]byte
so that clients can marshal into their own structs, and get rid ofreadStream
entirely.SynapseGo/read.go
Lines 11 to 14 in 7a3e060
The text was updated successfully, but these errors were encountered: