Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile installs desktop files with executable permissions #667

Closed
notpeelz opened this issue Jan 24, 2024 · 1 comment
Closed

Makefile installs desktop files with executable permissions #667

notpeelz opened this issue Jan 24, 2024 · 1 comment

Comments

@notpeelz
Copy link
Contributor

Describe the bug
When installing syncplay, the desktop files get chmod-ed to 755. On my system (Arch Linux), syncplay is the only package that deploys desktop files with executable permissions.

/usr/share/applications:
image

Expected behavior
Permissions of 644, not 755. Desktop files aren't supposed to be executable.

Version and platform:

@daniel-123
Copy link
Contributor

I've traced back the specific code that changes those permissions to a commit with several changes almost 10 years ago. There was no explanation why .desktop files needed executable permissions in it.

I see no reason not to change them to follow what all the other .desktop files do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants