Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIRF-Contribs BSREM example truncates outer edge of FOV #44

Open
KrisThielemans opened this issue Jul 8, 2024 · 0 comments
Open

SIRF-Contribs BSREM example truncates outer edge of FOV #44

KrisThielemans opened this issue Jul 8, 2024 · 0 comments
Assignees
@KrisThielemans
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@KrisThielemans
Copy link
Member

https://github.com/SyneRBI/SIRF-Contribs/blob/018583ed8b728401da820d2c0d5eaa875340d752/src/Python/sirf/contrib/BSREM/BSREM.py#L33 and https://github.com/SyneRBI/SIRF-Contribs/blob/018583ed8b728401da820d2c0d5eaa875340d752/src/Python/sirf/contrib/BSREM/BSREM.py#L51

This is not described in our problem description, and explains why the ISTA example can give edge-of-FOV-ring effects while the BSREM one doesn't.
@KrisThielemans KrisThielemans mentioned this issue Jul 8, 2024
Merged
@casperdcl casperdcl added bug Something isn't working documentation Improvements or additions to documentation labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrisThielemans KrisThielemans

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KrisThielemans @casperdcl