Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previous install can cause compilation problems for newer versions #28

Open
KrisThielemans opened this issue Jul 16, 2017 · 1 comment
Labels
Milestone

Comments

@KrisThielemans
Copy link
Member

external packages are installed (by default in INSTALL, and therefore include files in INSTALL/include). This works fine at first build. However, when the include files of one of the external packages get updated, it is possible that the installed versions get found first (as opposed to the include files of the external package), resulting in compilation failures or segmentation faults.

Example:

Boost gets installed in INSTALL/include. STIR as well. STIR's CMakeLists.txt has

include_directories(${Boost_INCLUDE_DIRS})

before adding its own include directory to the compiler path. This is arguably a bug in STIR, but it is possible that other packages have the same problem.

Possible solution

If every package would be installed in its own directory, this problem would not occur. This is somewhat ugly though and means we will need to take care of passing the relevant paths along.

@KrisThielemans
Copy link
Member Author

STIR bug filed in UCL/STIR#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant