New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resampler.process deprecation #700
Comments
Hum, two possible solutions:
Personally, between the first two, I'm in favour of the second. As you say, I suppose we could change the signature of |
|
@AnderBiguri this is the resampler. it doesn't return a DVF (that's the job of the registration) |
Not sure what you mean, can you give an example? The DVFs are the same regardless of forward/adjoint. Anyway, I'm fairly sure that under the hood, |
@KrisThielemans @rijobro let me go and buy stronger coffee, completely misread all this. Sorry! |
SIRF/src/Registration/cReg/NiftyResample.cpp Lines 190 to 194 in 225d621
|
Obviously, all this The As I don't really want to create a lot of work now without proper discussion, I suggest that we undeprecate I see that the UserGuide is out-of-date on the methods for the resampling in any case. |
PR to un-deprecate For what it's worth, I think this is a pretty good warning!
|
Sure, that warning is crystal clear. It's the cruft around it that more distracting than anything else. Anyway. not our issue. |
SIRF-exercises registration demo does
but gives warning
Aide from the fact that Python/jupyter could work on their user-friendliness of their errors (I'm sure @AnderBiguri would agree 😉), my question is if we should have deprecated this.
For registration people, the original syntax is straghtforward (you set-up the registration that way, so you do the same for the resampler). The
forward
is slightly less easy to grasp in this context.I'm not sure about what the best is. @rijobro @ckolbPTB ?
Of course, ideally we don't have this warning in the SIRF-exercises, but first we need to know what to do.
The text was updated successfully, but these errors were encountered: