Deluge missing chardet dep.

[mhertz]

I'm relaying a report from marcun from the deluge forum, about a plugin not working(yarss2) because errors out with missing chardet dep. On other distro's like arch and ubuntu etc, then python(3)-chardet is a deluge dep, as per directly listed in requirements.txt from upstream. I built a version of the plugin with chardet included directly, but thought to also report here, hope you don't mind.

Thanks in advance.

https://forum.deluge-torrent.org/viewtopic.php?p=236192#p236192 (Includes debug log with the missing dep referenced)

[th0ma7]

@mhertz I've created a PR to fix this. Once the build pipeline finishes would you mind testing out the updated package to confirm it's all good? https://github.com/SynoCommunity/spksrc/pull/5676/checks

[mhertz]

Knew I could count on you th0ma7 :) Thanks alot, I really appreciate it!

Would love to, but unfortunetly it's impossible for me(did infact check if possible spin up a VM of syno or something lol, for help testing), but anyway I asked the reporter to please do so if possible and report back.

I'm sure your fix good, as I also took that wheel from pypi, extracted, and added to sys.path in the yarss2 build I posted on forum as workaround, though later used the 4.0.0 version of chardet as per pinned in deluge's requirements.txt, but they both work fine I tested(not though tested in syno as said)

Again, much appreciated!

Edit: I thought I had explained originally, but didn't I see, i'm sorry - the reason I said hope you don't mind, was that a) i'm not really a syno user, just deluge forum member, and b) for making general request and not bug-report, as I cannot input the needed info of the bug-request, like NAS model and whatnot. Sorry for breaking the rules probably - I though only post when i'm certain that i'm not wrong / wasting your time, but still.

Edit2: I really am sorry th0ma7, I see 'pip install deluge' doesn't install chardet either, which I thought was a mistake then, and was sure remembered official deluge install instructions said to install from requirements.txt but I see now remembered wrong(and requirements.txt just used on windows builds in CI). Anyway, chardet is listed in requirements.txt(would be nice if it had a comment appended about it being optional), though specifically is listed under extras_require section of setup.py, and not install_requires(so only deluge[all] installs it) + is mentioned in depends.md as an optional dep, so I completely missed the mark, and just got confused by chardet not being an optional dep in arch and ubuntu + remembered the official install instructions wrong. ...And just after I posted I only post when sure not wrong lol, I feel so 'effing stupid now, and really apologize again. So is up to you, well always was of-course, but I mean if think this is warrented or not i.e. I could make a request to yarss2 dev about if he would please consider including chardet as direct included dep, since is an optional dep from upstream apparently. Sorry again for possibly wasting your time, seriously didn't ment for that!

[mar-cun]

Hey, a month late and a dollar short, so sorry. But I can confirm (for what it's worth) that this did indeed fix the issue. I was the original reporter that @mhertz helped out! Sorry I didn't see this sooner!