Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromaprint tools [$100 awarded] #902

Closed
rednoah opened this issue Mar 30, 2014 · 27 comments
Closed

Chromaprint tools [$100 awarded] #902

rednoah opened this issue Mar 30, 2014 · 27 comments
Assignees
Labels
beta bounty request request for new package

Comments

@rednoah
Copy link

rednoah commented Mar 30, 2014

Has anyone managed to compile fpcalc (and the ffmpeg dependencies) with the DSM toolchains?

http://acoustid.org/chromaprint

The $100 bounty on this issue has been claimed at Bountysource.

@rednoah
Copy link
Author

rednoah commented Mar 26, 2015

Added bounty for contributing a Chromaprint fpcalc command-line utility make instructions to spksrc so that packages we can get it as package from SynoCommunity and all Synology platform.

Bountysource

@cytec
Copy link
Member

cytec commented Mar 26, 2015

@rednoah if ffmpeg is the only dependence that should be doable

@rednoah
Copy link
Author

rednoah commented Mar 26, 2015

Lukas, the developer of fpcalc, already got it working specifically for arm7hf just to see if it's feasible. Works fine here, but only for DS213J and the likes. I don't know exactly how he did it though. I never got it compiling with spksrc with any of the toolkits. If there was packages for all platforms that would be really nice.

@cytec
Copy link
Member

cytec commented Mar 26, 2015

well there is already a boost package in cross and also an ffmpeg seems like the only missing depend is taglib and then it should be working ;)

Maybe i can take a look if i got access to my VM again

@rednoah
Copy link
Author

rednoah commented Mar 26, 2015

Sure, let me know if you need help with testing. Lukas is also really nice in helping, as long as you generally know what you're doing I guess. :D

@isujinx
Copy link

isujinx commented Mar 26, 2015

There was some good explanation of the compiling process for chromaprint on the Bliss site, but this is way over my head programming wise. I'd just like to see a fpcalc package! Not sure how to add the bounty thing like rednoah - but I'd throw in $20 to see it done.

@cytec
Copy link
Member

cytec commented Mar 27, 2015

I'll probably/hopefully have access to my VM tomorrow... hopefully i can give it a try then.
keep you updated

@cytec
Copy link
Member

cytec commented Mar 28, 2015

@rednoah good news got it working on my DS1513+ (cedarview):

daenerys>LD_LIBRARY_PATH=/usr/local/chromaprint/lib  /usr/local/chromaprint/bin/fpcalc
usage: /usr/local/chromaprint/bin/fpcalc [OPTIONS] FILE...

Options:
  -version      print version information
  -length SECS  length of the audio data used for fingerprint calculation (default 120)
  -raw          output the raw uncompressed fingerprint
  -algo NAME    version of the fingerprint algorithm    

@cytec
Copy link
Member

cytec commented Mar 28, 2015

seems that somehow rlink is not working correctly but i don't know how to set it correctly for cmake... maybe @Diaoul or @Dr-Bean have an idea on that? current code is available here:
cytec@62f78d0

@Diaoul
Copy link
Member

Diaoul commented Mar 28, 2015

@cytec: IDK but this seems to explain a lot of variables involved in the RPATH stuff.

@cytec
Copy link
Member

cytec commented Mar 29, 2015

got it thanks :)

@cytec
Copy link
Member

cytec commented Mar 29, 2015

@Diaoul is there a way to make a PLIST file for spk also? seems like there is a lot of stuff generated which isn't needed at all (ffmpeg binaries etc)

@Diaoul
Copy link
Member

Diaoul commented Mar 29, 2015

Filtering out some stuff can be done in a extra install rule like python.
PLIST filtering for SPK is not implemented yet. If you want you can give it
a shot.

@rednoah
Copy link
Author

rednoah commented Mar 29, 2015

If you need some testing for armada370 builds let me know.

@isujinx
Copy link

isujinx commented Mar 29, 2015

Not that I'll be terribly helpful in troubleshooting, but let me know if you need Intel testing.

Glad you got it working!

@cytec
Copy link
Member

cytec commented Mar 30, 2015

i've compiled a version for armada370 and currently doing a x64 compile.
Test SPK's will be available here:
https://cytec.us/syno/test-spk/chromaprint/

@rednoah can you test?
this only installs fpcalc to /usr/local/chromaprint/bin/fpcalc atm any feedback is welcome

@cytec
Copy link
Member

cytec commented Mar 30, 2015

@Diaoul @rednoah asked to link fpcalc to /usr/local/bin or /usr/bin what do you think? personally i'm not really a fan of linking binaries and would leave that to the user...

@rednoah
Copy link
Author

rednoah commented Mar 30, 2015

Works well on armada370.

If you don't wanna link the binary into the $PATH thats fine for me. I can hardcode /usr/local/chromaprint/bin/fpcalc into my lookup path.

@cytec
Copy link
Member

cytec commented Mar 30, 2015

Nice!
yeah i think that'll be the prefered way, lets wait for @Diaoul to comment his thoughts on that but i'm pretty sure he doesn't like linking it anywhere :D

@Diaoul
Copy link
Member

Diaoul commented Mar 30, 2015

Well for command line only utilities it's accepted to link binaries into /usr/local/bin. For example mc and nano (PR pending) do that.

@cytec
Copy link
Member

cytec commented Mar 30, 2015

ok i'll change the link to /usr/local/bin then

@isujinx
Copy link

isujinx commented Mar 31, 2015

x64 Build works great! I ran filebot's sysinfo, it found my old version of fpcalc, deleted it and ran sysinfo, and it failed fpcalc. Then installed the spk from the test site, modified filebot.sh back to the original place it looked for fpcalc, ran sysinfo and it found the new version of fpcalc!

Great work!

@cytec
Copy link
Member

cytec commented Apr 7, 2015

seems like i can rename my PR and remove the WIP? anyone getting any errors/problems so far?

@rednoah
Copy link
Author

rednoah commented Apr 9, 2015

No problems on my DS213J (armada370) so far.

@Dr-Bean
Copy link
Contributor

Dr-Bean commented Apr 26, 2015

Chromaprint 1.2-1 has been published on the repository on the beta channel. I'll leave this issue open for feedback, for now.

@Diaoul
Copy link
Member

Diaoul commented May 2, 2015

@cytec: you can also claim that bounty I believe

@Diaoul Diaoul added request request for new package beta labels May 2, 2015
@rednoah
Copy link
Author

rednoah commented May 2, 2015

I'm not sure how Bounty Source works, but I think it's linked to this GitHub issue, so if this issue is closed then the bounty should be claimable.

@rednoah rednoah closed this as completed May 2, 2015
@Diaoul Diaoul changed the title Chromaprint tools Chromaprint tools [$100 awarded] Jun 4, 2015
@Diaoul Diaoul added the bounty label Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta bounty request request for new package
Projects
None yet
Development

No branches or pull requests

5 participants