Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If NETWORK_NAME is set from an env var then changeMetamaskNetwork() can't be used to change metamask network #253

Closed
drptbl opened this issue Oct 27, 2021 · 3 comments
Assignees
Labels
bug 🐛 Something isn't working

Comments

@drptbl
Copy link
Member

drptbl commented Oct 27, 2021

#252 (comment)

Reported by @DimitarTAtanasov

@drptbl
Copy link
Member Author

drptbl commented Oct 27, 2021

cc @DimitarTAtanasov

Should be fixed by tomorrow morning. Thanks for reporting 🙏.

@drptbl
Copy link
Member Author

drptbl commented Oct 28, 2021

Hey @DimitarTAtanasov,

This one should be fixed now. You can freely change your network from your tests.

I've also added a support for metamask notifications related to site requesting a network change or adding a new network to metamask:
https://github.com/Synthetixio/synpress/blob/master/support/index.d.ts#L158-L187

Please use: @synthetixio/synpress@1.0.0 and let me know how it goes.

Thanks for awesome feedback - it really helps to improve synpress.

Let me know if you need anything, happy to help.

All Best,
Jakub.

@DimitarTAtanasov
Copy link

Thanks @drptbl that's is great news, thanks a lot for your help. Will come back to you if I have any other suggestions.

All best,
Dimitar

@drptbl drptbl closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants