Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svf filter cuts too much high frequencies in default position #179

Closed
sichtbeton opened this issue Jul 10, 2023 · 6 comments
Closed

Svf filter cuts too much high frequencies in default position #179

sichtbeton opened this issue Jul 10, 2023 · 6 comments

Comments

@sichtbeton
Copy link
Contributor

The new svf filter is great. The only issue I found is that when engaged, the filter cuts a lot of high frequencies by default. So doing a filter move is not really possible because there is no way to get the original sound when svf is selected.

@m-m-adams
Copy link
Collaborator

m-m-adams commented Jul 10, 2023

Oddly enough this is a duplicate of #173 (same underlying issue)

@sichtbeton
Copy link
Contributor Author

Oddly enough this is a duplicate of #173 (same underlying issue)

Should I close this issue then?

@m-m-adams m-m-adams mentioned this issue Jul 19, 2023
@m-m-adams
Copy link
Collaborator

@sichtbeton can you test a new build and confirm whether this is now good enough? It's still off by a factor of sin(f)/f compared to the ladders so it matches almost exactly at low frequencies but is at about 17khz instead of 22khz fully open

@sichtbeton
Copy link
Contributor Author

@sichtbeton can you test a new build and confirm whether this is now good enough? It's still off by a factor of sin(f)/f compared to the ladders so it matches almost exactly at low frequencies but is at about 17khz instead of 22khz fully open

Ok, checked it just now. It's much better now! There is still a audible difference when put under the microscope (DT770 Pro headphones), so it's loosing a bit of the high freqs when fully open compared to 12db / 24db filters. "Drive" reacts completely different (louder than the rest) so I would ignore this.

So would most users notice it? Probably not and if so only the nerds. Could there be a bit more high freqs when fully open? Sure.

@m-m-adams
Copy link
Collaborator

Makes sense - I'll try to address it more completely as I get through #105

@m-m-adams
Copy link
Collaborator

Closing for now - will be done in #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants