Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random and S&H LFOs, triplet and dotted LFO sync #26

Closed
4 tasks done
phfalk opened this issue Jun 8, 2023 · 6 comments
Closed
4 tasks done

Random and S&H LFOs, triplet and dotted LFO sync #26

phfalk opened this issue Jun 8, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@phfalk
Copy link
Contributor

phfalk commented Jun 8, 2023

I always wanted to have some more randomness for modulation that changes more frequently than the "Random" modulation source which only outputs a new random value every time a note is triggered. How I imagine this to work:

  • Add LFO that just outputs a random value every time it is called. This might be a little too jittery to be useful
    • sort of working but more noisy than musical
  • Add another LFO that takes a random value and holds it for some time until a new random value is generated
  • Explore what kinds of smoothing or restrictions in terms of how far subsequent values can be from each other would be useful
  • Now that I understand more about how the LFOs work, next step could be triplet or maybe even dotted LFO sync timings
@jamiefaye jamiefaye added the enhancement New feature or request label Jun 8, 2023
@phfalk phfalk changed the title Random and S&H LFOs Random and S&H LFOs, triplet and dotted LFO sync Jun 8, 2023
@alex-reid
Copy link

I've been looking into dotted notes for sync settings. From what I can gather at a high level, sync setting are stored as an int from 0 to 9 with that number being a divisor for the sync length hence why the sync settings are whole steps. My thoughts around this are that maybe implementing a bool for dotted notes along with the 0 to 9 sync settings might be the way to go.

Looking at @dctucker's excellent class diagrams, the UI side of things is handled by MenuItemSyncLevel and is fed to the arp, delay, lfo and sidechain.

I can't currently get the toolchain set up because i'm on a mac, but if I did, I'd probably approach it by trying to get the UI working and then delve into getting it hooked up to the individual things that work off that.

@phfalk
Copy link
Contributor Author

phfalk commented Jun 20, 2023

Corresponding MR was merged

@phfalk phfalk closed this as completed Jun 20, 2023
@manysounds
Copy link

Current community build (c95a27c) LFO shape buttons hang the machine.

@sapphire-arches
Copy link
Collaborator

That was a bug due to the menu item refactor, please try the latest nightly: https://github.com/SynthstromAudible/DelugeFirmware/actions/runs/5827496457

The pages site build is broken so it is currently out of date.

@sapphire-arches
Copy link
Collaborator

Actually that won't have some other fixes to know bugs, latest build is here: https://github.com/SynthstromAudible/DelugeFirmware/actions/runs/5830090263

In the future, please prefer opening new bugs to commenting on closed ones 😅

@manysounds
Copy link

Couldn’t navigate to the right place, apologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants