Morphable and Driveable and Parallel filters #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-m-adams
changed the title
m-m-adams
force-pushed
the
morphable_filters
branch
from
755de01
to
cb92947
Compare
… avoid future mistakes
m-m-adams
force-pushed
the
morphable_filters
branch
from
cb92947
to
448379c
Compare
Merged
via the queue into
SynthstromAudible:community
with commit Aug 11, 2023
04faf18
2 checks passed
|
Ey maybe too late to the party but i installed latest commit from community branch and when in HPF and mode is SVF as soon as i turn the golden knob a little bit i get no sound at all, like adding a little bit of cutoff in HPF-SVF breaks the audio output of that clip. Anyone experienced this? @m-m-adams |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Add an SVF option to the HPF slot, set for HPF mode by default. This can be modified through the menu, shortcuts, or clicking the lower knob while HPF is selected.
Adds a 3rd filter paramater called morph, placed in the menu and on the pads under the db/oct on filters. Morph smoothly morphs the SVF through LP-BP-HP, and smoothly increases drive in the ladder filters. This param is modulatable and automatable
Adds a setting to switch the filter order or run them in parallel. This setting is menu only and named ROUTE
Refactors more of the ladder code to remove dead code paths