Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: refactor ecFSEOF for GECKO3 model format #300

Closed
3 tasks
ae-tafur opened this issue Apr 3, 2023 · 0 comments · Fixed by #301
Closed
3 tasks

bug: refactor ecFSEOF for GECKO3 model format #300

ae-tafur opened this issue Apr 3, 2023 · 0 comments · Fixed by #301
Assignees
@ae-tafur
Labels
bug fixed in develop Has already been addressed in develop branch

Comments

@ae-tafur
Copy link
Collaborator

ae-tafur commented Apr 3, 2023

Description of the bug:

GECKO 2 names protein exchange reactions as 'draw_*' or 'prot_', but GECKO 3 rename this to 'usage_prot'. In addition, enzymes, MWs and other fields are now under ec field. These changes have not been reflected yet.

I hereby confirm that I have:

  • Tested my code with all requirements for running GECKO
  • Done this analysis in the main branch of the repository
  • Checked that a similar issue does not exist already
@ae-tafur ae-tafur added the bug label Apr 3, 2023
@ae-tafur ae-tafur self-assigned this Apr 3, 2023
@edkerk edkerk changed the title Bug: ecFSEOF run on model based on GECKO 2 feat: refactor ecFSEOF for GECKO3 model format Apr 3, 2023
@edkerk edkerk changed the title feat: refactor ecFSEOF for GECKO3 model format bug: refactor ecFSEOF for GECKO3 model format Apr 3, 2023
@edkerk edkerk linked a pull request May 12, 2023 that will close this issue
Bug: Fix compatibility running ecFSEOF with GECKO3 models #301
Merged
1 task
@edkerk edkerk added the fixed in develop Has already been addressed in develop branch label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ae-tafur ae-tafur

Labels
bug fixed in develop Has already been addressed in develop branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug: Fix compatibility running ecFSEOF with GECKO3 models SysBioChalmers/GECKO
2 participants
@edkerk @ae-tafur