Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorships in Zenodo releases #223

Closed
1 task done
BenjaSanchez opened this issue May 27, 2020 · 3 comments · Fixed by #241
Closed
1 task done

authorships in Zenodo releases #223

BenjaSanchez opened this issue May 27, 2020 · 3 comments · Fixed by #241
Assignees
Labels
doc documentation fixed in devel this issue is already fixed in devel and will be closed after the next release

Comments

@BenjaSanchez
Copy link
Collaborator

Description of the issue:

In our releasing guidelines we don't have any specification on how to assign authorships for each new Zenodo release (so all of them so far have the same authors). I can manually edit them to be more consistent, but some questions for discussion before:

  • Should all contributors be included in all releases, or only contributors that committed to each specific release?
  • What about contributors that did not commit? (e.g. PR reviewers, commenters in issues, supervisors, etc.)

@edkerk @Hao-Chalmers how are you handling this in RAVEN?

I hereby confirm that I have:

  • Checked that a similar issue does not exist already
@BenjaSanchez BenjaSanchez added question ideas/feedback from other people would be appreciated doc documentation labels May 27, 2020
@BenjaSanchez BenjaSanchez self-assigned this May 27, 2020
@haowang-bioinfo
Copy link
Member

haowang-bioinfo commented May 27, 2020

This issue hasn't been addressed in RAVEN yet.

It makes sense to only include committers as contributors to a release, maybe also reviewers.

@edkerk
Copy link
Member

edkerk commented May 27, 2020

As @Hao-Chalmers said, we haven't addressed this in RAVEN, we've only been considering authorship with releasing major updates (= new publication).

I'd argue that committers are not the only ones making a valuable contribution to new releases (see e.g. #220, PR reviews can be quite extensive). There is a risk that this encourages people to Approve a PR without thorough Review, just to be included in the authorlist, but this is just for the Zenodo releases, so the reward is probably too low for this to become a problem.

Commenters can be left out by default, but what about Issue-starters, who highlighted a bug but did not fix it themselves (so did not author a PR)?

I'd leave out supervisors by default, if they have an active role then they would co-author or review the PR and be included by that criteria. Make clear that this is just for the Zenodo releases, paper authorship can also be justified for providing the funding, general supervision etc.

@BenjaSanchez
Copy link
Collaborator Author

BenjaSanchez commented Jun 25, 2020

I corrected manually all authorships to include both committers and reviewers. I left out issue starters, as I think in many cases it doesn't make sense (often it's just someone noticing a bug), and it could mean considerably more work for the admin (some users don't have their actual name as Github handle, and some might not give their consent to be considered authors). I also opened #233 to update the admin guidelines. Unless there are any other points to bring up, this can be closed after the next release.

@BenjaSanchez BenjaSanchez added fixed in devel this issue is already fixed in devel and will be closed after the next release and removed question ideas/feedback from other people would be appreciated labels Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc documentation fixed in devel this issue is already fixed in devel and will be closed after the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants