Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite errors #31

Closed
speedst3r opened this issue May 22, 2019 · 6 comments
Closed

SQLite errors #31

speedst3r opened this issue May 22, 2019 · 6 comments

Comments

@speedst3r
Copy link

I came across a couple of errors running pykms_Server with SQLite - don't have the actual errors anymore but you could probably replicate them.

  1. 'os' is not defined, pykms_Sql.py, line 17. - Added 'import os', 7e40ba6
  2. 'self' is not defined, pykms_Sql.py line 78. - removed 'self' from the connection reference, 5441771
@speedst3r
Copy link
Author

Command line to launch py-kms:

/usr/bin/python3 pykms_Server.py 0.0.0.0 1688 -l 1033 -c 26 -a 120 -r 10080 -s -w RANDOM -V INFO -F /var/log/pykms_server.log

@elekgeek
Copy link

elekgeek commented May 23, 2019

thanks for the command, but there are a couple of errors in the code, in file pykms_Sql.py as follows:

add import os at the beginning of this file, right after #!/usr/bin/env python3
and at line 78, modify:
con = sqlite3.connect(self.dbName)
to
con = sqlite3.connect(dbName)

this should solve your issue.

@speedst3r
Copy link
Author

speedst3r commented May 23, 2019

Yeah - it's my PR (#32) with these fixes (and the commits in the issue opening post from my fork), before taking it out of draft I wanted it confirmed that it was an issue and not something in my environment.

@elekgeek
Copy link

sorry man, I did not read your first msg and thought you were looking for the solution, my bad..

Any way, I tested it with office 2019 and it works ok with the fix :)

@speedst3r
Copy link
Author

No worries. I have a CI pipeline that builds a Docker image, currently the Dockerfile is using my fork, once the PR is merged I can submit a PR for my updated Dockerfile and start.sh, and can revert to using the upstream repo :)

@SystemRage
Copy link
Owner

Many thanks for debug and contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants