Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of favorites not working #314

Closed
martin-schwenke opened this issue Sep 11, 2022 · 0 comments · Fixed by #323
Closed

Import of favorites not working #314

martin-schwenke opened this issue Sep 11, 2022 · 0 comments · Fixed by #323

Comments

@martin-schwenke
Copy link

I am generally unable to import favorites.

At some point my favorites list was corrupted. I have cleared it and importing reliably fails. Usually the progress bar pops up and disappears, but there are no favorites in my list. This happens on 2 very different Android phones (LG V30+, running an old version of Android; Motorola Edge 20 Fusions with Android 11).

I can reduce the list to just this:

538 - Security

and import still fails.

No odd characters there:

$ hexdump -C favorites.txt
00000000  35 33 38 20 2d 20 53 65  63 75 72 69 74 79 0a     |538 -
Security.|
0000000f

I was able to import several exported favorites files after first marking a single recent comic as a favorite. However, I have just tried to re-test this and import silently fails.

The favorite importing code looks quite simple, so I can't see what could be going wrong.

Any ideas?

Thanks...

thgoebel added a commit to thgoebel/Easy_xkcd that referenced this issue Jan 23, 2023
Fixes tom-anders#314.
The problem was that when iterating over the favourite import,
nearly all comic to be imported where never cached,
and hence not in the database,
and hence the UPDATE statement did not find any entry it could update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant