Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maven Central Repository to pom file for all Service Repos using Github Actions. #3

Closed
8 tasks done
kaladay opened this issue Jan 20, 2021 · 0 comments
Closed
8 tasks done
Assignees

Comments

@kaladay
Copy link

kaladay commented Jan 20, 2021

Without Maven Central Repository added, builds under Github Actions sometimes fail due to incorrectly attempting to get Projects from the TAMU file repositories instead of the appropriate ones. Adding Maven Central Repository should resolve this issue.

The problem appears to be network/github related, but this is unclear.
It seems that github, sometimes inconsistently fails to fetch files from maven centrals default repository.
By adding the mirror, an alternative repository is used in addition to maven central.
Failures are inconsistent and do not happen everytime, for example:

The first fails and the second passes, despite being the same commits.
The package that fails is coincidental and will be different from time to time.
(For example here tomcat-embed-websocket-8.5.43.pom fails: https://github.com/TAMULib/CAP/runs/1728569099#step:8:6762 )

Adding what is essentially a second maven central repository to search for the files through adds robustness via the redundancy and helps reduce problems with githubs potential networking issues. For example, central represents the default maven repository and mvnrepository represents the added additional maven repository.
In CAP, this commit is fetching the file from central https://github.com/TAMULib/CAP/runs/1728973172?check_suite_focus=true#step:8:3033 but for a different file it fetches from mvnrepository https://github.com/TAMULib/CAP/runs/1728973172?check_suite_focus=true#step:8:3036 (after trying both tamu-releases and tamu-snapshots for the package spring-boot-dependencies-1.5.22.RELEASE.pom). It seems that for some reason it failed to fetch spring-boot-dependencies-1.5.22.RELEASE.pom from central and then attempts to fetch from the tamu repositories and finally the mvnrepository.

This essentially makes the mvnrepository a failsafe to use in the event central fails and the files are not on tamu-release and not on tamu-snapshots.

https://github.com/TAMULib/CAP/runs/1728973172?check_suite_focus=true#step:8:3033

See also:

The following need to be updated:

  • SAGE
  • CAP
  • LibraryServiceStatusSystemService
  • MetadataAssignmentToolService
  • GIFMButtonService
  • ProjectManagementService
  • CatalogService
  • The Private Repositories
@kaladay kaladay created this issue from a note in Github Actions Migration (To do) Jan 20, 2021
@kaladay kaladay moved this from To do to In progress in Github Actions Migration Jan 20, 2021
@kaladay kaladay self-assigned this Jan 20, 2021
@kaladay kaladay moved this from In progress to Review in Progress in Github Actions Migration Jan 21, 2021
@kaladay kaladay moved this from Review in Progress to Done in Github Actions Migration Jan 27, 2021
@ghost ghost moved this from Done to Review in Progress in Github Actions Migration Feb 3, 2021
Github Actions Migration automation moved this from Review in Progress to Accepted Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants