Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua: send memory domain as an argument #538

Closed
vadosnaprimer opened this issue Nov 14, 2015 · 0 comments
Closed

Lua: send memory domain as an argument #538

vadosnaprimer opened this issue Nov 14, 2015 · 0 comments
Assignees
Labels
re: Lua API/scripting Relating to EmuHawk's Lua API (not the Lua Console)

Comments

@vadosnaprimer
Copy link
Contributor

It always looks dirty when you have to change memory domains frequently since the game doesn't care and reads from a few of them in a row, and then you also must change it back to the domain you want.

I request ability to pass the needed memory domain as an optional parameter to memory.read/write() (and alike), the code will be way cleaner. Also, when there's only a single place where you need to use another domain, it's just easier to specify it directly than to add 2 more calls of usememorydomain just for that one case.

This obviously shouldn't change the global current region.

@vadosnaprimer vadosnaprimer changed the title send memory domain as an argument Lua: send memory domain as an argument Nov 14, 2015
@vadosnaprimer vadosnaprimer self-assigned this Dec 19, 2015
@YoshiRulz YoshiRulz added the re: Lua API/scripting Relating to EmuHawk's Lua API (not the Lua Console) label Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re: Lua API/scripting Relating to EmuHawk's Lua API (not the Lua Console)
Projects
None yet
Development

No branches or pull requests

2 participants