Skip to content

Commit

Permalink
fix #1246 the easy way
Browse files Browse the repository at this point in the history
  • Loading branch information
feos committed Sep 21, 2018
1 parent 39305d3 commit 57fd605
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion BizHawk.Client.EmuHawk/movie/PlayMovie.cs
Expand Up @@ -479,7 +479,13 @@ private void MovieView_SelectedIndexChanged(object sender, EventArgs e)
}
break;
case HeaderKeys.PLATFORM:
if (kvp.Value != Global.Game.System)
// feos: previously it was compared against Global.Game.System, but when the movie is created
// its platform is copied from Global.Emulator.SystemId, see PopulateWithDefaultHeaderValues()
// the problem is that for GameGear and SG100, those mismatch, resulting in false positive here
// I have a patch to make GG and SG appear as platforms in movie header (issue #1246)
// but even with it, for all the old movies, this false positive would have to be worked around anyway
// TODO: actually check header flags like "IsGGMode" and "IsSegaCDMode" (those are never parsed by bizhawk)
if (kvp.Value != Global.Emulator.SystemId)
{
item.BackColor = Color.Pink;
}
Expand Down

1 comment on commit 57fd605

@YoshiRulz
Copy link
Member

@YoshiRulz YoshiRulz commented on 57fd605 Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.