Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryCallbackSystem ActiveChanged only invoked on first Add #1159

Closed
gifvex opened this issue Mar 26, 2018 · 0 comments
Closed

MemoryCallbackSystem ActiveChanged only invoked on first Add #1159

gifvex opened this issue Mar 26, 2018 · 0 comments
Labels
re: Lua API/scripting Relating to EmuHawk's Lua API (not the Lua Console)

Comments

@gifvex
Copy link
Contributor

gifvex commented Mar 26, 2018

See: MemoryCallbackSystem.cs

This is an issue for cores that rely on the event handler to pass callbacks in:

https://github.com/TASVideos/BizHawk/blob/519e14aa1ad7a9d6df2edc7808c5ed687dfee046/BizHawk.Emulation.Cores/Consoles/Nintendo/Gameboy/Gambatte.IDebuggable.cs#L74-L84

For example, if onmemoryexecute is called from lua, it will run RefreshMemoryCallbacks with only HasExecutes as true. Any calls to onmemorywrite or onmemoryread will still register the functions on the lua end, but the function pointer for those collections will never be passed to the core.

@gifvex gifvex changed the title lua: MemoryCallbackSystem ActiveChanged only invoked on first Add MemoryCallbackSystem ActiveChanged only invoked on first Add Mar 26, 2018
alyosha-tas added a commit that referenced this issue May 12, 2018
@YoshiRulz YoshiRulz added the re: Lua API/scripting Relating to EmuHawk's Lua API (not the Lua Console) label Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re: Lua API/scripting Relating to EmuHawk's Lua API (not the Lua Console)
Projects
None yet
Development

No branches or pull requests

2 participants