Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCEHawk may be missing an audio channel. #1580

Closed
EZGames69 opened this issue May 29, 2019 · 30 comments
Closed

PCEHawk may be missing an audio channel. #1580

EZGames69 opened this issue May 29, 2019 · 30 comments
Labels
Core: PCEHawk (Alt.) PC Engine (PCE) / TurboGrafx-16 (TG-16) / SuperGrafx core Working as intended (wontfix) Intended behaviour perceived as a bug, or an unreasonable feature request

Comments

@EZGames69
Copy link

I was comparing my TAS for Splatterhouse on PCE to an actual console and I noticed somthing about the first level in particular.

On console it seems like there are more Percussion sound effects playing. On Bizhawk, however, it just sounds like it's playing Hi-Hats.

here's what it sounds like on Console

and here's what it sounds like on bizhawk(my TAS)

if you compare the music from the first level, you can definitely tell that BizHawk is either missing sound effects or it's not playing the correct sounds. I also believe the audio is accurate on PCEjin.

@YoshiRulz YoshiRulz added the Core: PCEHawk (Alt.) PC Engine (PCE) / TurboGrafx-16 (TG-16) / SuperGrafx core label May 29, 2019
@ghost
Copy link

ghost commented Jun 6, 2019

PCEHawk is a lost cause

Use OoTake or Mednafen..... Or even old magic engine.

@EZGames69
Copy link
Author

Use those for TASing? I dont think those emulators are allowed for TASVideos anymore.

@alyosha-tas
Copy link
Contributor

PCEHawk is certainly our weakest core, but I wouldn't say it's a lost cause, it's more just that we don't have the coding manpower to fix it. No one has the time / interest. And by no one I basically mean me.

But there is an unimplemented part of the PSG in PCEHawk that might be causing your problem.

case 8: // LFO
					// TODO: implement LFO
					break;
				case 9: // LFO Control
					if ((value & 0x80) == 0 && (value & 3) != 0)
					{
						Console.WriteLine("****************      LFO ON !!!!!!!!!!       *****************");
						Channels[1].Enabled = false;
					}
					else
					{
						Channels[1].Enabled = true;
					}
					break;

This is not implemented. If you open the console window in Bizhawk (View -> Display log Window, then restart bizhawk completely.) And you see the LFO ON!!!!! text appear when the drums should be playing, you know where your problem is.

Here is a great resource for the PCE PSG:

http://www.magicengine.com/mkit/doc_hard_psg.html

If the LFO is indeed your problem, why not take a shot at implementing it? It looks pretty easy and should be tractable even for a beginner.

@EZGames69
Copy link
Author

I should impliment it? I dont know the first thing about coding for emulators. I could at least see if that text is showing up like you said.

@ghost
Copy link

ghost commented Jun 7, 2019

Why would mednafen or ootake be banned from TASsing. they are cycle accurate. the pcehawk core is garbage.

@EZGames69
Copy link
Author

Well we can assume it is due to better emulation, but this is the only resource I can find right now: http://tasvideos.org/Bizhawk/PCE.html

If a TASVideos Staff member wants to explain it then that would be appreciated.

@ghost
Copy link

ghost commented Jun 8, 2019

That link is dated. Better emulation lol. Not even comparable let alone better. The two I mentioned are cycle accurate. The bizhawk pce core is hot garage and not even close to accurate. Also note the other two currently hold 100% compatibility while being cycle accurate. You can't be better than 100% especially when your missing sound channels and full of graphical glitches. Bizhawk is awesome but it's pce core is horrendous by today's standards

@EZGames69
Copy link
Author

I’d like to see a source for this 100% number your getting.

@alyosha-tas
Copy link
Contributor

Pcejin is still accepted for tases.

Yeah that link should be edited, PCEHawk has not aged well at all.

An issue for porting a different core (ex mednafen) has been open for a while now, I think it will remain open for a while longer. Realistically we don’t have enough people to keep BizHawk updated. PCE and Apple II are the hardest hit but even gba is long overdue for an update.

@Sonia-7
Copy link

Sonia-7 commented Jun 8, 2019

And that's why I refrain from making movies on pcehawk until the mednafen core gets ported over, or, if by some miracle pcehawk gets fixed to the point it becomes as accurate as mednafen (which would probably be far more difficult).

By the way, I'm curious about something. Would porting mednafen's pce core be that much harder than say, the Saturn or PS1 ones (both of which have been already available in bizhawk for a while)?

@alyosha-tas
Copy link
Contributor

For what it's worth I removed the language in the Bizhawk section of TASVideos about PCEHawk being better then other emulators.

@alyosha-tas
Copy link
Contributor

And that's why I refrain from making movies on pcehawk until the mednafen core gets ported over, or, if by some miracle pcehawk gets fixed to the point it becomes as accurate as mednafen (which would probably be far more difficult).

By the way, I'm curious about something. Would porting mednafen's pce core be that much harder than say, the Saturn or PS1 ones (both of which have been already available in bizhawk for a while)?

Probably not, but once again it's a matter of interest and time. Fixing PCEHawk wouldn't be more difficult necessarily, since a lot of underlying infrastructure works already. I think PCEHawk isn't as broken as is perceived, it just doesn't have anyone who wants to work on it.

@EZGames69 Did you check whether or not the message pops up for the missing LFO stuff?

@EZGames69
Copy link
Author

I haven’t yet and I probably wont be able to do it for the next few days.

@EZGames69
Copy link
Author

The message does not pop up.

@ghost
Copy link

ghost commented Aug 4, 2019

Would it be possible to allow the emulator to do a core overide for pce and use the mednafen sgx liberto core dll to be used?

@YoshiRulz
Copy link
Member

Not currently, for the simple reason of "overcomplication" given in #1375.

@EZGames69
Copy link
Author

I have tested Splatterhouse in the new waterboxed core and it sounds closer to what it should be on console.

@ghost
Copy link

ghost commented May 30, 2020

I have tested Splatterhouse in the new waterboxed core and it sounds closer to what it should be on console.

2.4.2 and last appveyor build i tried still use pce hawk. I havnt been online alot, life got crazy. But im dead curious is this waterbox core you speak of mednafen??? If so it is the accurate core or fast? This is exciting.

@EZGames69
Copy link
Author

It’s in the latest dev build.

When you get it, go to config->cores->PCE->TerboGrapic(it’s a weird spelling), then reboot the core. You should be able to use it then.

@ghost
Copy link

ghost commented May 30, 2020

Awesome, gonna test a bit yay!

@ghost
Copy link

ghost commented May 30, 2020

Im loving this. Is this based on the latest accurate mednafen core? Seems like it

@ghost
Copy link

ghost commented May 30, 2020

1.24.3 yay wow awesome!!!

@ghost
Copy link

ghost commented May 30, 2020

In my current testing i see one thing they forgot when water boxing this, ability to set autofire rate (mednafen core supports this) all other important things there

@nattthebear
Copy link
Contributor

In my current testing i see one thing they forgot when water boxing this, ability to set autofire rate (mednafen core supports this) all other important things there

Separate issue please, this is about audio problems in a different core

@ghost
Copy link

ghost commented May 30, 2020

Its been a Turbografx 16 aka PCEngine weekend here and they waterboxed core is running perfect!! So happy this core was waterboxed!

@nattthebear
Copy link
Contributor

Well, if it works there I'm canning this issue

@adelikat
Copy link
Contributor

Autofire rate is handed with config -> autofire, and is not core dependent

@ghost
Copy link

ghost commented May 31, 2020

Autofire rate is handed with config -> autofire, and is not core dependent

Yes, my bad. So happy you guys did this!

@EZGames69
Copy link
Author

EZGames69 commented May 31, 2020

I sotra disagree with closing this ticket as it’s specifically talking about PCEHawk’s audio. Just because we have a new core doesn’t mean the issue in PCEHawk is gone.

Like what if someone in the future is interested in fixing the bugs in PCEHawk?

@vadosnaprimer
Copy link
Contributor

vadosnaprimer commented May 31, 2020

PCEHawk is to be mercy killed soon. Same scenario as vba-next.

@YoshiRulz YoshiRulz added the Working as intended (wontfix) Intended behaviour perceived as a bug, or an unreasonable feature request label May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core: PCEHawk (Alt.) PC Engine (PCE) / TurboGrafx-16 (TG-16) / SuperGrafx core Working as intended (wontfix) Intended behaviour perceived as a bug, or an unreasonable feature request
Projects
None yet
Development

No branches or pull requests

7 participants