Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GBHawk] Audio playback is screwed up with Pokemon Crystal #2006

Closed
EZGames69 opened this issue May 14, 2020 · 3 comments
Closed

[GBHawk] Audio playback is screwed up with Pokemon Crystal #2006

EZGames69 opened this issue May 14, 2020 · 3 comments
Labels
Core: GBHawk Game Boy / Color (GB/GBC) core Repro: Fixed/added in 2.5

Comments

@EZGames69
Copy link

Noticed with this TAS submission: http://tasvideos.org/6746S.html

Audio has this weird static noise with some tracks. Most noticably with the intro theme with Professor Oak. And other tracks have some weird background echo to them (like the hometown theme).

Note that Alt Sync does not fix this issue. This is the case for both GBHawk and SubGBHawk.

also tested myself to confirm it: https://www.youtube.com/watch?v=EWUnVrEKD_U

@YoshiRulz YoshiRulz added the Core: GBHawk Game Boy / Color (GB/GBC) core label May 15, 2020
@YoshiRulz
Copy link
Member

YoshiRulz commented May 15, 2020

(edit: is the bug in movie playback reproducible in...) 2.4.1?

@CasualPokePlayer
Copy link
Member

2.4.1?

My submission used 2.4.1, yes.

@alyosha-tas
Copy link
Contributor

I'm calling this fixed, it sounds much better now. Audio emulation in general needs more filtering, but when I added a high pass filter experimentally it didn't help anything here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core: GBHawk Game Boy / Color (GB/GBC) core Repro: Fixed/added in 2.5
Projects
None yet
Development

No branches or pull requests

4 participants