Save files not cleared when using savestates on bios

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Load Game & Watch Gallery 4
2. Select the core as mGBA OR go to settings and select Skip Bios to FALSE.
3. During the bios boot, make a savestate
4. Wait until the game loads and shows a red backdrop.
5. Load the savestate.

What is the expected output? What do you see instead?
http://i.imgur.com/KfB0cXz.png
I should be seeing the red background with 102 lag frames consistently.


What version of the product are you using? On what operating system?
BizHawk-1.10.0 Windows 8.1

Please provide any additional information below.
Technically works in any game with a save, but since Game & Watch gallery 4 
autosaves, and its appearances is red at blank file but blue when you save, 
that was used as an example.

Original issue reported on code.google.com by lunjess...@gmail.com on 18 Jun 2015 at 1:56

[GoogleCodeExporter]

Doesn't the BIOS setting get saved in the savestate?  I would think it should 
at least.

Original comment by hegyak on 18 Jun 2015 at 4:20

• Added labels: Core-GBAHawk, OpSys-Any, Priority-Medium

[GoogleCodeExporter]

I checked with mGBA using BIOS on and off.  To see what changes (if anything).

BIOS Skip On, Orange/Red Background.  Reboot Core, Blue Background.
BIOS Skip Off, Orange/Red Background.  Reboot Core, Blue Background.

The SRAM is not being cleared/ignored when I select Record Movie (after 
accepting the warning).  Applies to Both Cores.  Tested consistently against 
r9426.

Original comment by hegyak on 20 Jun 2015 at 3:12

• Changed state: Accepted
• Added labels: Core-EmuHawk
• Removed labels: Core-GBAHawk

[nattthebear]

I'm able to easily reproduce this on mGBA; savedata is not being stored in savestates. I'm not able to reproduce this at all on VBANext.

[zeromus]

Whether savedata should go in savestates is some kind of controversial topic I'm not sure I've ever heard resolved clearly, it's possible for different programmers to have selected different approaches without ever knowing it. Major pain in the butt. Anyway, the needs of TASing should resolve it firmly in favor of keeping savedata in savestates, but many casual gamers hate it.

[nattthebear]

a1f3b3d