Gambatte x lua and fix #1159 #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One other thing I noticed with Gambatte is that the scanline register is only intermittently updated when looking at trace logs. Do you think it would be possible (and easy) to continuously update this? It's fine if not, I just happen to remember it and thought it would be a useful thing to include in this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements TotalExecutedCycles for Gambatte after a general cleanup of its MemoryCallbacks. Gambatte uses its internal cycle counter as an arbitrary timer, so the callbacks use relative values to accurately represent executed cycles.
Included is a fix for #1159 (cores unable to receive multiple callback types). UpdateHasVariables now returns a bool indicating if anything changed.