Port DeSmuME to GTK+ 3.24 #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All deprecation warnings are disabled for now, they will be reenabled at a later point.
At this point, this version builds. It is full of deprecated widgets and functions though, which will have to be cleaned over time. It also doesn’t display any visuals in the DS emulation part yet.
The expose_event signal has been renamed draw.
At this point we got a fully (?) functional gtk3 port, but it uses a ton of deprecated functions that will be removed in gtk4. Better enable the warnings so that we know what to fix before then.
If we want to change the style of a widget, we should use CSS nowadays.
This one uses the native file chooser the user is used to, which can be GTK’s on Linux but a more familiar one on other OSes. If xdg-desktop-portal is installed, it can even use the DE’s native one on Linux.
This will make it possible to use GAction to replace the deprecated GtkAction and GtkToggleAction and such.
…device_position()
|
Nobody is going to test a fork, you will have to push it to master for anyone to test it. Then the test will be in the form of people reporting regressions as github bugs. So fix the bugs you know about and then I'll merge it. |
This is now using an action parameter to send the slot to save to/load from. There was a previous comment about Shift-Fn being broken and a workaround using Key_Press(), but it doesn’t seem to be broken anymore so we can use the accelerators instead and remove a static variable.
This now only uses GtkRecentManager to populate the menu.
|
Here, quick savestate access from the menu, as well as recent files are now working properly. I believe this could get merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My end goal is GTK 4 support, but this seems like a good first step.
I’ve also added a meson build system, as it’s much more developer-friendly than autotools, and is getting widely adopted.
Please test the various features, amongst known broken is the recent file list (but you can use the recent file opener in the GTK+ open dialog).
I have only tested on Linux, but I see no reason it wouldn’t work elsewhere too, especially since meson supports Visual Studio.
Amongst my future plans for this GUI are:
clang-format.GtkBuilderstrings out in other files, possibly usingGResourceto keep them inside of the final executable.GtkGLArea, so that it works on Wayland without requiring Xwayland.Fixes part of #209.