Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickname from previous website version now appears as a separate contributor #734

Closed
100thCoin opened this issue Jan 2, 2022 · 9 comments
Labels
bug Priority: Low User-Facing Issue that is very low priority

Comments

@100thCoin
Copy link

For my recent published TASs, since usernames cannot begin with a number, I have opted to write my username out as "OnehundredthCoin", and entered "100th_Coin" as the nickname field when submitting. Since the upgrade, my TAS now lists both "OnehundredthCoin" and "100th_Coin" as the creators.

https://tasvideos.org/4567M

@bigbass1997
Copy link

Hmm, API reports only one author for the pub: "OnehundredthCoin". The title may just be formatting the nickname wrong. In comparison, the submission's header text does properly display just the nickname.

@Masterjun3
Copy link
Collaborator

This was due to the old site only having strings as publication and submission titles, thus needing manual conversion. This was done and checked on the end of October 2021, so player entries that changed afterwards might be affected.

This doesn't need a fix in the code and instead a fix on the site. Both submissions and publications need to be fixed.

Here is a list of affected publications (and their submissions) I found back when I first noticed the problem:

@vadosnaprimer
Copy link
Collaborator

Cleaned up those. What other movies need this?

@Masterjun3
Copy link
Collaborator

Their submissions need the change as well.

@TiKevin83 TiKevin83 added bug Priority: Low User-Facing Issue that is very low priority labels Jan 4, 2022
@TiKevin83 TiKevin83 added this to the 2.3 Release - Post Go-Live milestone Jan 12, 2022
@adelikat
Copy link
Collaborator

Looks like submissions were fixed too, can this be closed?

@Masterjun3
Copy link
Collaborator

The submissions still aren't fixed heh.

@Masterjun3
Copy link
Collaborator

Here is what exactly to do to close this issue:

@vadosnaprimer
Copy link
Collaborator

They changed their names after I fixed the publications. So where it was still wrong I did a blank edit for pubs so the right name is picked, and also I fixed the submissions.

@adelikat
Copy link
Collaborator

Closing this. This conversation doesn't belong here, this is non-dev work. If submissions/publication names are wrong, let's post in a topic (or the topic of the incorrect pub/sub) and have the conversation there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Priority: Low User-Facing Issue that is very low priority
Projects
None yet
Development

No branches or pull requests

6 participants