Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include game version into publication name #906

Closed
vadosnaprimer opened this issue Jan 10, 2022 · 9 comments
Closed

Include game version into publication name #906

vadosnaprimer opened this issue Jan 10, 2022 · 9 comments
Labels
Game System The Game, System, and related tables for organizing site content Publication System Youtube integration All things related to the site interaction with Youtube

Comments

@vadosnaprimer
Copy link
Collaborator

Sometimes we publish different region versions separately
https://tasvideos.org/Movies-2413M-2648M
so it's important to show those versions as a part of movie name, like it was on the old site:

PSX Tenchu: Stealth Assassins (USA) by Hâthor in 29:52.65
PSX Tenchu: Stealth Assassins (JPN) by xxNKxx in 16:34.17

It also makes sense to include version into youtube name.

@meshuggahtas meshuggahtas added Publication System Youtube integration All things related to the site interaction with Youtube Game System The Game, System, and related tables for organizing site content labels Jan 10, 2022
@Masterjun3
Copy link
Collaborator

I wonder if it would be worth it to create a flag for each publication telling whether it's necessary to show the game version.
Showing it seems to be unnecessary for the majority of movies, yet absolutely necessary for some.

@vadosnaprimer
Copy link
Collaborator Author

vadosnaprimer commented Jan 10, 2022

Ah that sounds like we should have an optional field in pubs where this version would be displayed as an arbitrary string, and rom version/revision would be a separate thing. The former is decorative, the latter is for internal bookkeeping.

A whole bunch of movies has any or unknown and it was dumb to display the latter, even tho it was default. Any was hidden too.

@meshuggahtas
Copy link
Collaborator

meshuggahtas commented Jan 10, 2022

Unknown means unknown country. It has information value when there are other game versions with known country.

I don't know about Any as game version for Goodsets.

edit: It makes sense to have an optional field for adding/not adding version to pub name

@vadosnaprimer
Copy link
Collaborator Author

I mean the old site had unknown as default, and for games without versions it just printed unknown in the pub name, which is useless.

@adelikat
Copy link
Collaborator

The old site had loosely tied text. New site has a strong tie to Game and Rom. To do this, we need Rom information for the publication to get the version from there. Currently we don't have so many roms set up

@vadosnaprimer
Copy link
Collaborator Author

I created ROM entries but versions are still not displayed in pub name.
https://tasvideos.org/Movies-2413M-2648M

@ViGadeomes
Copy link

I agree with this issue and I would like to propose to also add the version in the submission system list because when two movies of the same game with different regional versions can be published side by side and submited at the same time, It can be a little bit confusing.

@vadosnaprimer
Copy link
Collaborator Author

There's a submission whose acceptance is kinda blocked by not having this info displayed
https://tasvideos.org/Forum/Posts/511550

@adelikat
Copy link
Collaborator

Fixed enough for now, could be improved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game System The Game, System, and related tables for organizing site content Publication System Youtube integration All things related to the site interaction with Youtube
Projects
None yet
Development

No branches or pull requests

5 participants