Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients.py httpsConnection Python version check error #224

Closed
melegar opened this issue Jun 1, 2017 · 3 comments
Closed

clients.py httpsConnection Python version check error #224

melegar opened this issue Jun 1, 2017 · 3 comments

Comments

@melegar
Copy link

melegar commented Jun 1, 2017

in the init function for VerifiableHTTPSConnection in clients.py the first step is to do a python version check. However, the script only looks for python 2.6, 2.7 or 3.4. If someone is running Python version 3.5 or 3.6 the script will fail with the Unsupported Python version error.

@melegar
Copy link
Author

melegar commented Jun 1, 2017

I believe this error can be resolved by editing clients.py lines 431 and 454 to remove the statement "and sys.version_info.minor == 4"

@gtback
Copy link
Contributor

gtback commented Jun 1, 2017

Link to relevant code:

elif ((sys.version_info.major == 2 and sys.version_info.minor == 7)
or (sys.version_info.major == 3 and sys.version_info.minor == 4)):

Also related to #222 (in that we should probably fix them both at the same time).

@gtback gtback added this to the libtaxii 1.1.111 milestone Jun 1, 2017
@gtback
Copy link
Contributor

gtback commented Jun 1, 2017

Thanks, @melegar

@gtback gtback closed this as completed in 3d22495 Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants