generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 7
/
validate.go
622 lines (558 loc) · 19.5 KB
/
validate.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
//nolint:nakedret
package schema
import (
"fmt"
"reflect"
"regexp"
"slices"
"sort"
"strings"
"github.com/alecthomas/participle/v2"
"github.com/alecthomas/types/optional"
"github.com/TBD54566975/ftl/internal/cron"
"github.com/TBD54566975/ftl/internal/errors"
dc "github.com/TBD54566975/ftl/internal/reflect"
islices "github.com/TBD54566975/ftl/internal/slices"
)
var (
// Primitive types can't be used as identifiers.
//
// We don't need Array/Map/Ref here because there are no
// keywords associated with these types.
primitivesScope = Scope{
"Int": ModuleDecl{Symbol: &Int{}},
"Float": ModuleDecl{Symbol: &Float{}},
"String": ModuleDecl{Symbol: &String{}},
"Bytes": ModuleDecl{Symbol: &Bytes{}},
"Bool": ModuleDecl{Symbol: &Bool{}},
"Time": ModuleDecl{Symbol: &Time{}},
"Unit": ModuleDecl{Symbol: &Unit{}},
"Any": ModuleDecl{Symbol: &Any{}},
}
)
// MustValidate panics if a schema is invalid.
//
// This is useful for testing.
func MustValidate(schema *Schema) *Schema {
clone, err := ValidateSchema(schema)
if err != nil {
panic(err)
}
return clone
}
// ValidateSchema clones, normalises and semantically validates a schema.
func ValidateSchema(schema *Schema) (*Schema, error) {
return ValidateModuleInSchema(schema, optional.None[*Module]())
}
// ValidateModuleInSchema clones and normalises a schema and semantically validates a single module within it.
// If no module is provided, all modules in the schema are validated.
//
//nolint:maintidx
func ValidateModuleInSchema(schema *Schema, m optional.Option[*Module]) (*Schema, error) {
schema = dc.DeepCopy(schema)
modules := map[string]bool{}
merr := []error{}
ingress := map[string]*Verb{}
// Inject builtins.
builtins := Builtins()
// Move builtins to the front of the list.
schema.Modules = slices.DeleteFunc(schema.Modules, func(m *Module) bool { return m.Name == builtins.Name })
schema.Modules = append([]*Module{builtins}, schema.Modules...)
scopes := NewScopes()
// Validate dependencies
if err := validateDependencies(schema); err != nil {
merr = append(merr, err)
}
// First pass, add all the modules.
for _, module := range schema.Modules {
if module == builtins {
continue
}
if err := scopes.Add(optional.None[*Module](), module.Name, module); err != nil {
merr = append(merr, err)
}
}
// Validate modules.
for _, module := range schema.Modules {
// Skip builtin module, it's already been validated.
if module.Name == "builtin" {
continue
}
if v, ok := m.Get(); ok && v.Name != module.Name {
// Don't validate other modules when validating a single module.
continue
}
if _, seen := modules[module.Name]; seen {
merr = append(merr, errorf(module, "duplicate module %q", module.Name))
}
modules[module.Name] = true
if err := ValidateModule(module); err != nil {
merr = append(merr, err)
}
indent := 0
err := Visit(module, func(n Node, next func() error) error {
save := scopes
if scoped, ok := n.(Scoped); ok {
scopes = scopes.PushScope(scoped.Scope())
defer func() { scopes = save }()
}
indent++
defer func() { indent-- }()
switch n := n.(type) {
case *Ref:
mdecl := scopes.Resolve(*n)
if mdecl == nil {
merr = append(merr, errorf(n, "unknown reference %q", n))
break
}
if decl, ok := mdecl.Symbol.(Decl); ok {
if mod, ok := mdecl.Module.Get(); ok {
n.Module = mod.Name
}
if n.Module != module.Name && !decl.IsExported() {
merr = append(merr, errorf(n, "%s %q must be exported", typeName(decl), n.String()))
}
if dataDecl, ok := decl.(*Data); ok {
if len(n.TypeParameters) != len(dataDecl.TypeParameters) {
merr = append(merr, errorf(n, "reference to data structure %s has %d type parameters, but %d were expected",
n.Name, len(n.TypeParameters), len(dataDecl.TypeParameters)))
}
} else if len(n.TypeParameters) != 0 && !decl.IsExported() {
merr = append(merr, errorf(n, "reference to %s %q cannot have type parameters", typeName(decl), n.Name))
}
} else {
if _, ok := mdecl.Symbol.(*TypeParameter); !ok {
merr = append(merr, errorf(n, "invalid reference %q at %q", n, mdecl.Symbol.Position()))
}
}
case *Verb:
for _, md := range n.Metadata {
md, ok := md.(*MetadataIngress)
if !ok {
continue
}
// Check for duplicate ingress keys
key := md.Method + " "
for _, path := range md.Path {
switch path := path.(type) {
case *IngressPathLiteral:
key += "/" + path.Text
case *IngressPathParameter:
key += "/{}"
}
}
if existing, ok := ingress[key]; ok {
merr = append(merr, errorf(md, "duplicate %s ingress %s for %s:%q and %s:%q", md.Type, key, existing.Pos, existing.Name, n.Pos, n.Name))
}
ingress[key] = n
}
case *Enum:
if n.IsValueEnum() {
for _, v := range n.Variants {
if reflect.TypeOf(v.Value.schemaValueType()) != reflect.TypeOf(n.Type) {
merr = append(merr, errorf(v, "enum variant %q of type %s cannot have a value of "+
"type %q", v.Name, n.Type, v.Value.schemaValueType()))
}
}
} else {
for _, v := range n.Variants {
if _, ok := v.Value.(*TypeValue); !ok {
merr = append(merr, errorf(v, "type enum variant %q value must be a type, was %T",
v.Name, n))
}
}
}
return next()
case *FSM:
if len(n.Start) == 0 {
merr = append(merr, errorf(n, "%q has no start states", n.Name))
}
for _, start := range n.Start {
if sym, decl := ResolveAs[*Verb](scopes, *start); decl == nil {
merr = append(merr, errorf(start, "unknown start verb %q", start))
} else if sym == nil {
merr = append(merr, errorf(start, "start state %q must be a sink", start))
} else if sym.Kind() != VerbKindSink {
merr = append(merr, errorf(start, "start state %q must be a sink but is %s", start, sym.Kind()))
}
}
case *FSMTransition:
if sym, decl := ResolveAs[*Verb](scopes, *n.From); decl == nil {
merr = append(merr, errorf(n.From, "unknown source verb %q", n.From))
} else if sym == nil {
merr = append(merr, errorf(n.From, "source state %q is not a verb", n.From))
}
if sym, decl := ResolveAs[*Verb](scopes, *n.To); decl == nil {
merr = append(merr, errorf(n.To, "unknown destination verb %q", n.To))
} else if sym == nil {
merr = append(merr, errorf(n.To, "destination state %q is not a sink", n.To))
} else if sym.Kind() != VerbKindSink {
merr = append(merr, errorf(n.To, "destination state %q must be a sink but is %s", n.To, sym.Kind()))
}
case *Array, *Bool, *Bytes, *Data, *Database, Decl, *Field, *Float,
IngressPathComponent, *IngressPathLiteral, *IngressPathParameter,
*Int, *Map, Metadata, *MetadataCalls, *MetadataDatabases, *MetadataCronJob,
*MetadataIngress, *MetadataAlias, *Module, *Optional, *Schema, *TypeAlias,
*String, *Time, Type, *Unit, *Any, *TypeParameter, *EnumVariant, *MetadataRetry,
Value, *IntValue, *StringValue, *TypeValue, *Config, *Secret, Symbol, Named:
}
return next()
})
if err != nil {
merr = append(merr, err)
}
}
merr = cleanErrors(merr)
return schema, errors.Join(merr...)
}
var validNameRe = regexp.MustCompile(`^[A-Za-z_][A-Za-z0-9_]*$`)
// ValidateName validates an FTL name.
func ValidateName(name string) bool {
return validNameRe.MatchString(name)
}
// ValidateModule performs the subset of semantic validation possible on a single module.
//
// It ignores references to other modules.
func ValidateModule(module *Module) error {
merr := []error{}
scopes := NewScopes()
if !ValidateName(module.Name) {
merr = append(merr, errorf(module, "module name %q is invalid", module.Name))
}
if module.Builtin && module.Name != "builtin" {
merr = append(merr, errorf(module, "the \"builtin\" module is reserved"))
}
if err := scopes.Add(optional.None[*Module](), module.Name, module); err != nil {
merr = append(merr, err)
}
scopes = scopes.Push()
// Key is <type>:<name>
duplicateDecls := map[string]Decl{}
_ = Visit(module, func(n Node, next func() error) error {
if scoped, ok := n.(Scoped); ok {
pop := scopes
scopes = scopes.PushScope(scoped.Scope())
defer func() { scopes = pop }()
}
if n, ok := n.(Decl); ok {
tname := typeName(n)
duplKey := tname + ":" + n.GetName()
if dupl, ok := duplicateDecls[duplKey]; ok {
merr = append(merr, errorf(n, "duplicate %s %q, first defined at %s", tname, n.GetName(), dupl.Position()))
} else {
duplicateDecls[duplKey] = n
}
if !ValidateName(n.GetName()) {
merr = append(merr, errorf(n, "%s name %q is invalid", tname, n.GetName()))
} else if _, ok := primitivesScope[n.GetName()]; ok {
merr = append(merr, errorf(n, "%s name %q is a reserved word", tname, n.GetName()))
}
}
switch n := n.(type) {
case *Ref:
mdecl := scopes.Resolve(*n)
if mdecl == nil && n.Module == "" {
merr = append(merr, errorf(n, "unknown reference %q", n))
}
if mdecl != nil {
moduleName := ""
if m, ok := mdecl.Module.Get(); ok {
moduleName = m.Name
}
switch decl := mdecl.Symbol.(type) {
case *Verb, *Enum, *Database, *Config, *Secret:
if n.Module == "" {
n.Module = moduleName
}
if len(n.TypeParameters) != 0 {
merr = append(merr, errorf(n, "reference to %s %q cannot have type parameters", typeName(decl), n.Name))
}
case *Data:
if n.Module == "" {
n.Module = moduleName
}
if len(n.TypeParameters) != len(decl.TypeParameters) {
merr = append(merr, errorf(n, "reference to data structure %s has %d type parameters, but %d were expected",
n.Name, len(n.TypeParameters), len(decl.TypeParameters)))
}
case *TypeParameter:
default:
if n.Module == "" {
merr = append(merr, errorf(n, "unqualified reference to invalid %s %q", typeName(decl), n))
}
}
} else if n.Module == "" || n.Module == module.Name { // Don't report errors for external modules.
merr = append(merr, errorf(n, "unknown reference %q", n))
}
case *Verb:
merr = append(merr, validateVerbMetadata(scopes, module, n)...)
case *Data:
for _, md := range n.Metadata {
if md, ok := md.(*MetadataCalls); ok {
merr = append(merr, errorf(md, "metadata %q is not valid on data structures", strings.TrimSpace(md.String())))
}
}
case *Field:
for _, md := range n.Metadata {
if _, ok := md.(*MetadataAlias); !ok {
merr = append(merr, errorf(md, "metadata %q is not valid on fields", strings.TrimSpace(md.String())))
}
}
case *Array, *Bool, *Database, *Float, *Int,
*Time, *Map, *Module, *Schema, *String, *Bytes,
*MetadataCalls, *MetadataDatabases, *MetadataIngress, *MetadataCronJob, *MetadataAlias,
IngressPathComponent, *IngressPathLiteral, *IngressPathParameter, *Optional,
*Unit, *Any, *TypeParameter, *Enum, *EnumVariant, *IntValue, *StringValue, *TypeValue,
*FSM, *Config, *FSMTransition, *Secret, *TypeAlias, *MetadataRetry:
case Named, Symbol, Type, Metadata, Value, Decl: // Union types.
}
return next()
})
merr = cleanErrors(merr)
sort.SliceStable(module.Decls, func(i, j int) bool {
iDecl := module.Decls[i]
jDecl := module.Decls[j]
iPriority := getDeclSortingPriority(iDecl)
jPriority := getDeclSortingPriority(jDecl)
if iPriority == jPriority {
return iDecl.GetName() < jDecl.GetName()
}
return iPriority < jPriority
})
return errors.Join(merr...)
}
// getDeclSortingPriority (used for schema sorting) is pulled out into it's own switch so the Go sumtype check will fail
// if a new Decl is added but not explicitly prioritized
func getDeclSortingPriority(decl Decl) int {
priority := 0
switch decl.(type) {
case *Config:
priority = 1
case *Secret:
priority = 2
case *Database:
priority = 3
case *TypeAlias:
priority = 4
case *Enum:
priority = 5
case *FSM:
priority = 6
case *Data:
priority = 7
case *Verb:
priority = 8
}
return priority
}
// Sort and de-duplicate errors.
func cleanErrors(merr []error) []error {
if len(merr) == 0 {
return nil
}
merr = errors.DeduplicateErrors(merr)
// Sort by position.
sort.Slice(merr, func(i, j int) bool {
var ipe, jpe participle.Error
if errors.As(merr[i], &ipe) && errors.As(merr[j], &jpe) {
ipp := ipe.Position()
jpp := jpe.Position()
return ipp.Line < jpp.Line || (ipp.Line == jpp.Line && ipp.Column < jpp.Column)
}
return merr[i].Error() < merr[j].Error()
})
return merr
}
type dependencyVertex struct {
from, to string
}
type dependencyVertexState int
const (
notExplored dependencyVertexState = iota
exploring
fullyExplored
)
func validateDependencies(schema *Schema) error {
// go through schema's modules, find cycles in modules' dependencies
// First pass, set up direct imports and vertex states for each module
// We need each import array and vertex array to be sorted to make the output deterministic
imports := map[string][]string{}
vertexes := []dependencyVertex{}
vertexStates := map[dependencyVertex]dependencyVertexState{}
for _, module := range schema.Modules {
currentImports := module.Imports()
sort.Strings(currentImports)
imports[module.Name] = currentImports
for _, imp := range currentImports {
v := dependencyVertex{module.Name, imp}
vertexes = append(vertexes, v)
vertexStates[v] = notExplored
}
}
sort.Slice(vertexes, func(i, j int) bool {
lhs := vertexes[i]
rhs := vertexes[j]
return lhs.from < rhs.from || (lhs.from == rhs.from && lhs.to < rhs.to)
})
// DFS to find cycles
for _, v := range vertexes {
if cycle := dfsForDependencyCycle(imports, vertexStates, v); cycle != nil {
return fmt.Errorf("found cycle in dependencies: %s", strings.Join(cycle, " -> "))
}
}
return nil
}
func dfsForDependencyCycle(imports map[string][]string, vertexStates map[dependencyVertex]dependencyVertexState, v dependencyVertex) []string {
switch vertexStates[v] {
case notExplored:
vertexStates[v] = exploring
for _, toModule := range imports[v.to] {
nextV := dependencyVertex{v.to, toModule}
if cycle := dfsForDependencyCycle(imports, vertexStates, nextV); cycle != nil {
// found cycle. prepend current module to cycle and return
cycle = append([]string{nextV.from}, cycle...)
return cycle
}
}
vertexStates[v] = fullyExplored
return nil
case exploring:
return []string{v.to}
case fullyExplored:
return nil
}
return nil
}
func errorf(pos interface{ Position() Position }, format string, args ...interface{}) error {
return Errorf(pos.Position(), pos.Position().Column, format, args...)
}
func validateVerbMetadata(scopes Scopes, module *Module, n *Verb) (merr []error) {
// Validate metadata
metadataTypes := map[reflect.Type]bool{}
for _, md := range n.Metadata {
reflected := reflect.TypeOf(md)
if _, seen := metadataTypes[reflected]; seen {
merr = append(merr, errorf(md, "verb can not have multiple instances of %s", strings.ToLower(strings.TrimPrefix(reflected.String(), "*schema.Metadata"))))
continue
}
metadataTypes[reflected] = true
switch md := md.(type) {
case *MetadataIngress:
reqBodyType, reqBody, errs := validateIngressRequestOrResponse(scopes, module, n, "request", n.Request)
merr = append(merr, errs...)
_, _, errs = validateIngressRequestOrResponse(scopes, module, n, "response", n.Response)
merr = append(merr, errs...)
// Validate path
for _, path := range md.Path {
switch path := path.(type) {
case *IngressPathParameter:
reqBodyData, ok := reqBody.(*Data)
if !ok {
merr = append(merr, errorf(path, "ingress verb %s: cannot use path parameter %q with request type %s, expected Data type", n.Name, path.Name, reqBodyType))
} else if reqBodyData.FieldByName(path.Name) == nil {
merr = append(merr, errorf(path, "ingress verb %s: request type %s does not contain a field corresponding to the parameter %q", n.Name, reqBodyType, path.Name))
}
case *IngressPathLiteral:
}
}
case *MetadataCronJob:
_, err := cron.Parse(md.Cron)
if err != nil {
merr = append(merr, err)
}
if _, ok := n.Request.(*Unit); !ok {
merr = append(merr, errorf(md, "verb %s: cron job can not have a request type", n.Name))
}
if _, ok := n.Response.(*Unit); !ok {
merr = append(merr, errorf(md, "verb %s: cron job can not have a response type", n.Name))
}
case *MetadataRetry:
// Only allow retries on FSM transitions for now
fsms := islices.Filter(module.Decls, func(d Decl) bool {
fsm, ok := d.(*FSM)
if !ok {
return false
}
starts := islices.Filter(fsm.Start, func(ref *Ref) bool {
return ref.Name == n.Name
})
if len(starts) > 0 {
return true
}
transitions := islices.Filter(fsm.Transitions, func(t *FSMTransition) bool {
return t.To.Name == n.Name
})
return len(transitions) > 0
})
if len(fsms) == 0 {
merr = append(merr, errorf(md, "verb %s: retries can only be added to FSM transitions", n.Name))
return
}
// Validate count
if md.Count != nil && *md.Count <= 0 {
merr = append(merr, errorf(md, "verb %s: retry count must be atleast 1", n.Name))
}
// Validate parsing of durations
minDuration, err := md.MinBackoffDuration()
if err != nil {
merr = append(merr, errorf(md, "verb %s: %v", n.Name, err))
return
}
maxDuration, err := md.MaxBackoffDuration()
if err != nil {
merr = append(merr, errorf(md, "verb %s: %v", n.Name, err))
return
}
if maxDuration, ok := maxDuration.Get(); ok && maxDuration < minDuration {
merr = append(merr, errorf(md, "verb %s: max backoff duration (%s) needs to be atleast as long as initial backoff (%s)", n.Name, md.MaxBackoff, md.MinBackoff))
}
case *MetadataCalls, *MetadataDatabases, *MetadataAlias:
}
}
return
}
func validateIngressRequestOrResponse(scopes Scopes, module *Module, n *Verb, reqOrResp string, r Type) (fieldType Type, body Symbol, merr []error) {
rref, _ := r.(*Ref)
resp, sym := ResolveTypeAs[*Data](scopes, r)
m, _ := sym.Module.Get()
if sym == nil || m == nil || m.Name != "builtin" || resp.Name != "Http"+strings.Title(reqOrResp) {
merr = append(merr, errorf(r, "ingress verb %s: %s type %s must be builtin.HttpRequest", n.Name, reqOrResp, r))
return
}
resp, err := resp.Monomorphise(rref) //nolint:govet
if err != nil {
merr = append(merr, errorf(r, "ingress verb %s: %s type %s: %v", n.Name, reqOrResp, r, err))
return
}
scopes = scopes.PushScope(resp.Scope())
fieldType = resp.FieldByName("body").Type
if opt, ok := fieldType.(*Optional); ok {
fieldType = opt.Type
}
if ref, err := ParseRef(fieldType.String()); err == nil {
if ref.Module != "" && ref.Module != module.Name {
return // ignores references to other modules.
}
}
bodySym := scopes.ResolveType(fieldType)
if bodySym == nil {
merr = append(merr, errorf(r, "ingress verb %s: couldn't resolve %s body type %s", n.Name, reqOrResp, fieldType))
return
}
body = bodySym.Symbol
switch t := bodySym.Symbol.(type) {
case *Bytes, *String, *Data, *Unit, *Float, *Int, *Bool, *Map, *Array: // Valid HTTP response payload types.
case *Enum:
// Type enums are valid but value enums are not.
if t.IsValueEnum() {
merr = append(merr, errorf(r, "ingress verb %s: %s type %s must have a body of bytes, string, data structure, unit, float, int, bool, map, or array not enum %s", n.Name, reqOrResp, r, t.Name))
}
default:
merr = append(merr, errorf(r, "ingress verb %s: %s type %s must have a body of bytes, string, data structure, unit, float, int, bool, map, or array not %s", n.Name, reqOrResp, r, bodySym.Symbol))
}
return
}
// Give a type a human-readable name.
func typeName(v any) string {
return strings.ToLower(reflect.Indirect(reflect.ValueOf(v)).Type().Name())
}