Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert fake service footnotes #1522

Closed
wants to merge 5 commits into from
Closed

Conversation

Egerm010
Copy link
Contributor

@Egerm010 Egerm010 commented Feb 17, 2023

Pretty iffy on this one- in particular on what is meant to be used for the ID values of create_footnote. I looked through footnote.csv, but there were seemingly no examples to follow of service related footnotes except for a few that did not seem to give me any proper confirmation as to what to use for id values (perhaps that's intentional since they were originally fake).

Perhaps I've misunderstood what converting the "fake" footnotes to "proper form" meant however, and that doesn't mean making them real footnotes per say.

Feel free to tell me if I'm very far off track here or if there's anything I should change.

(Note: currently getting error when opening services now. I suspect this may be because this branch is not up to date with master, will rebase soon to check)

@Egerm010 Egerm010 force-pushed the Convert_fake_service_footnotes branch from 6c052a3 to fcdfe30 Compare March 10, 2023 15:18
@Steph-Rancourt Steph-Rancourt deleted the Convert_fake_service_footnotes branch July 14, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert existing "fake" footnotes from Service Inventory to proper form utilizing footnotes.csv
2 participants