Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TemporaryPublicAccountsBanner with a permanent solution #1600

Open
Stephen-ONeil opened this issue Dec 14, 2021 · 0 comments
Open

Replace TemporaryPublicAccountsBanner with a permanent solution #1600

Stephen-ONeil opened this issue Dec 14, 2021 · 0 comments

Comments

@Stephen-ONeil
Copy link
Contributor

Stephen-ONeil commented Dec 14, 2021

TemporaryPublicAccountsBanner is necessary to alert users to incomplete actual FTE data on relevant non-infographic routes. Something similar is potentially necessary for planning information at DP time.

Currently, it is an ad-hoc use of the core/NavComponents.js HeaderBanner component and centrally inserted in to the StandardRouteContainer component. That's hacky itself, and it also duplicates (and differs slightly) from the content of the government level infographic "warning panel" on the same topic.

Potential TODOs:

  • less hacky way to do this sort of temporary header banners, maybe as special footnotes tagged with relevant route names, make checking for and rendering them part of the StandardRouteContainer responsibilities?
  • de-duplicate content between TemporaryPublicAccountsBanner and the relevant late resource footnotes
  • make automatic for both PA late FTEs and late DP resources
  • consider using the pinned content wrapper on header banners (but only if it looks decent in practice/isn't too onerous)
@Stephen-ONeil Stephen-ONeil mentioned this issue Dec 14, 2021
7 tasks
@Stephen-ONeil Stephen-ONeil mentioned this issue Mar 2, 2022
1 task
@Steph-Rancourt Steph-Rancourt transferred this issue from TBS-EACPD/infobase Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from another repository Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from TBS-EACPD/private-temp Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from another repository Jun 6, 2024
@Steph-Rancourt Steph-Rancourt transferred this issue from TBS-EACPD/private-temp Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant